fix: use crypto/rand instead of math/rand for session certificate serial numbers #6417
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the use of math/rand with cyrpto/rand for generating X.509 certificate serial Numbers in the session certificate.
Generating math/rand.Int63() has several potential issues, probably not directly evident due to the worker and target residing in the private subnet, but still not an ideal way to generate it.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.