Icu 18014 inactive alert actions #3164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ui/admin/app/templates/scopes/scope/app-tokens/app-token/index.hbs
Outdated
Show resolved
Hide resolved
Comment on lines
+416
to
+417
| assert.dom('.hds-modal').isVisible(); | ||
| assert.dom('.hds-modal__header').containsText('Delete'); |
Collaborator
There was a problem hiding this comment.
Do we have a data-test attribute we can use here instead of the generic .hds-modal selector?
| assert.dom(selectors.DELETE_ORIGINAL_BANNER).isVisible(); | ||
|
|
||
| // Click the dismiss button | ||
| await click('[data-test-delete-original-banner] .hds-dismiss-button'); |
Collaborator
There was a problem hiding this comment.
Can we change this to a test selector const?
Comment on lines
+21
to
+39
| @tracked originalTokenWasInactive = false; | ||
|
|
||
| /** | ||
| * Stores the ID of the original app token being cloned. | ||
| * @type {string|null} | ||
| */ | ||
| @tracked originalTokenId = null; | ||
|
|
||
| /** | ||
| * Stores the name of the original app token being cloned. | ||
| * @type {string|null} | ||
| */ | ||
| @tracked originalTokenName = null; | ||
|
|
||
| /** | ||
| * Stores the status of the original app token being cloned. | ||
| * @type {string|null} | ||
| */ | ||
| @tracked originalTokenStatus = null; |
Collaborator
There was a problem hiding this comment.
non-blocking: I am curious if it would be easier to simply track the original app token model instead of 4 different tracked values? Not saying we should, just wanted to ask if it would clean this up a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the clone and delete button functionality for app token alerts. When an app token is inactive (stale, expired, or revoked) or has permissions with no active grant scopes, users can now clone or delete the token directly from the inline alert banners.
🎟️ Jira ticket
Screenshots (if appropriate)
inactive-app-tokens-demo.mov
How to Test
Inactive Token Alert
Delete Original Banner
No Active Scopes Alert (Permissions Page)
/addons/api/mirage/factories/app-tokens.jspageChecklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.