Skip to content

Conversation

@hashicc
Copy link
Collaborator

@hashicc hashicc commented Nov 25, 2025

Description

There are two spots in the api addon where we import from ember-inflector. To support these usages we should include ember-inflector as a dependency in some fashion. This supports the move to vite where imports have to be statically analyzable and dependencies should be declared in package.json.

How to Test

  1. Tests should continue to pass

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a11y-tests label to run a11y audit tests if needed

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@vercel
Copy link

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boundary-ui Ready Ready Preview, Comment Feb 10, 2026 3:11pm
boundary-ui-desktop Ready Ready Preview, Comment Feb 10, 2026 3:11pm

Request Review

@hashicc hashicc changed the title chore: 🤖 add missing dependency on ember-inflector (HOLD) chore: 🤖 add missing dependency on ember-inflector Nov 25, 2025
@hashicc hashicc self-assigned this Dec 3, 2025
@hashicc hashicc changed the title (HOLD) chore: 🤖 add missing dependency on ember-inflector (HOLD) chore: 🤖 add missing dependency on ember-inflector for api addon Dec 15, 2025
@hashicc hashicc mentioned this pull request Dec 15, 2025
10 tasks
@hashicc hashicc force-pushed the dependency-on-ember-inflector branch from 12ba418 to c7226a2 Compare February 3, 2026 21:11
@hashicc hashicc marked this pull request as ready for review February 3, 2026 21:12
@hashicc hashicc requested a review from a team as a code owner February 3, 2026 21:12
@hashicc hashicc changed the title (HOLD) chore: 🤖 add missing dependency on ember-inflector for api addon chore: 🤖 add missing dependency on ember-inflector for api addon Feb 3, 2026
@hashicc hashicc merged commit 46ededd into main Feb 10, 2026
13 checks passed
@hashicc hashicc deleted the dependency-on-ember-inflector branch February 10, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants