-
Notifications
You must be signed in to change notification settings - Fork 33
Refactor hds side nav to hds app side nav and header #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor hds side nav to hds app side nav and header #3032
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…https://github.com/hashicorp/boundary-ui into refactor-hds-side-nav-to-hds-app-side-nav-and-header
…https://github.com/hashicorp/boundary-ui into refactor-hds-side-nav-to-hds-app-side-nav-and-header
| --token-color-palette-neutral-100 | ||
| ); /* the toggle has a different base surface color, compared to the other controls */ | ||
|
|
||
| // Hds app side nav color-mappings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mappings are for dark mode and since there is no specific guideline for the side nav in dark mode, I tried to match the colors to the deprecated Hds::SideNav.
| color: var(--token-color-palette-neutral-300); | ||
| } | ||
|
|
||
| .hds-app-side-nav__list-item-link.active { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when a side nav list item is active in light mode its a dark blue color but there are color contrast a11y violations if same color is used in dark mode. So used a blue color token that has good contrast.
Description
Refactor admin & desktop UIs to use hds app side nav and app header components. This PR also removes components + styles that are no longer needed as a result of the refactor.
Screenshots (if appropriate)
How to Test
Checklist
a11y-testslabel to run a11y audit tests if neededPCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.