Add observation parameter name #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @adeckmyn , a differentiation between forecast parameter name and observation parameter name would indeed be useful.Cheers |
Collaborator
|
I totally lost track of this PR. Sorry. I'm looking into it. Maybe it would be more consistent to use ob_parameter not only as a replacement "fullname", but also to pass e.g. the different accumulation time of radar precipitation data, which is currently in a separate option. Also, maybe this should/could be solved in ob_file_opts. Not sure. Can you give some examples of obs parameter being different from forecast? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the parameter to be compared can be different in the model and in the observation file.
In verify_spatial I have added a new input named "ob_parameter" as an alternative to "parameter"