-
Notifications
You must be signed in to change notification settings - Fork 54
Add Swedish Language #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swedish Language #156
Conversation
translated strings added in snapshot changed HIDE_LYRICS to match HIDE_HIDDEN_FILES
changed MORE to be more accurate
Updated Swedish localization strings for clarity and accuracy.
Updated Swedish localization strings for improved accuracy and clarity.
Added Swedish language entry to index.json.
Summary of ChangesHello @Vinyx08, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the application's internationalization by integrating a complete Swedish language localization. This effort makes the application more accessible to a broader audience. Concurrently, it refines the existing Toki Pona localization, addressing previous translation inaccuracies and enhancing clarity for users of that language. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Swedish localization to the application, including the new sv_SE.json file and updates to README.md and index.json. The changes are well-structured. My review focuses on improving the quality and consistency of the Swedish translations. I've pointed out several instances of inconsistent terminology (e.g., "album" vs. "skiva"), incorrect translations that could confuse users (e.g., "property" as "fastighet"), and minor grammatical errors. I've also suggested removing some unnecessary empty lines from index.json. Additionally, this PR includes some welcome translation updates for Toki Pona, which look good.
localizations/sv_SE.json
Outdated
| "OPEN_FILE_OR_URL": "Öppna fil eller URL", | ||
| "OPEN_IN_BROWSER": "Öppna i webbläsare", | ||
| "OPTIONS": "Alternativ", | ||
| "ORDER": "Uppsättning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "PLAYLIST_CREATE_DIALOG_SUBTITLE": "Ange namn för spellistan", | ||
| "PLAYLIST_ADD_DIALOG_SUBTITLE": "Välj en spellista för att lägga till detta objekt", | ||
| "PLAYLIST_ADD_DIALOG_TITLE": "Lägg till i spellista", | ||
| "ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Now playing screen\" rippeleffekten", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "TAG_EDITOR_NO_TAGS_SUBTITLE": "Lägg till taggar för att organisera den här filen", | ||
| "TAG_EDITOR_NO_TAGS_TITLE": "Inga taggar hittades", | ||
| "TAG_EDITOR_REMOVE_COVER": "Ta bort omslaget", | ||
| "TAG_EDITOR_REMOVE_PROPERTY": "Ta bort fastighet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "ENABLE_ANIMATION_EFFECTS": "Aktivera animationseffekter", | ||
| "ENABLE_DISCORD_RPC": "Aktivera Discord RPC", | ||
| "ENABLE_NOTIFICATION_LYRICS": "Aktivera meddelanden om låttexter", | ||
| "ENTRIES": "Entréer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "PREVIOUS": "Föregående", | ||
| "PRIVACY": "Sekretess", | ||
| "PROCEED": "Fortsätt", | ||
| "PROPERTY": "Fastighet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index.json
Outdated
| ] | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "MONO": "Mono", | ||
| "MORE": "Mer", | ||
| "MUTE": "Tyst", | ||
| "M_ALBUMS_AND_N_TRACKS": "\"M\" skivor & \"N\" spår", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "MENU": "Meny", | ||
| "MIX": "Blanda", | ||
| "MOBILE_ALBUM_GRID_SIZE": "Albumrutnätets storlek", | ||
| "MOBILE_ARTIST_GRID_SIZE": "Konstnärens rutnätstorlek", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "NOW_YOU_ARE_GOOD_TO_GO_BACK": "Nu är du redo att åka tillbaka.", | ||
| "NO_FOLDERS_ADDED": "Inga mappar har lagts till", | ||
| "NO_PLAYLISTS_FOUND": "Inga spellistor hittades.\nSkapa några för att se dem där.", | ||
| "N_ALBUMS": "\"N\" skivor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "ADD_TO_NOW_PLAYING": "Lägg till nu spelande", | ||
| "ADD_TO_PLAYLIST": "Lägg till spellista", | ||
| "ALBUM": "Skiva", | ||
| "ALBUMS": "Skivor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
The checks are failing. I cannot merge unless you solve the issues. |
No description provided.