Skip to content

Conversation

@Vinyx08
Copy link

@Vinyx08 Vinyx08 commented Jan 11, 2026

No description provided.

SeliliPona and others added 30 commits January 9, 2026 00:03
translated strings added in snapshot
changed HIDE_LYRICS to match HIDE_HIDDEN_FILES
changed MORE to be more accurate
Updated Swedish localization strings for clarity and accuracy.
Updated Swedish localization strings for improved accuracy and clarity.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Vinyx08, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the application's internationalization by integrating a complete Swedish language localization. This effort makes the application more accessible to a broader audience. Concurrently, it refines the existing Toki Pona localization, addressing previous translation inaccuracies and enhancing clarity for users of that language.

Highlights

  • New Language Support: The application now supports the Swedish language, providing a fully localized user interface for Swedish speakers.
  • Toki Pona Localization Improvements: Several existing Toki Pona translations have been corrected and improved for better accuracy and user experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Swedish localization to the application, including the new sv_SE.json file and updates to README.md and index.json. The changes are well-structured. My review focuses on improving the quality and consistency of the Swedish translations. I've pointed out several instances of inconsistent terminology (e.g., "album" vs. "skiva"), incorrect translations that could confuse users (e.g., "property" as "fastighet"), and minor grammatical errors. I've also suggested removing some unnecessary empty lines from index.json. Additionally, this PR includes some welcome translation updates for Toki Pona, which look good.

"OPEN_FILE_OR_URL": "Öppna fil eller URL",
"OPEN_IN_BROWSER": "Öppna i webbläsare",
"OPTIONS": "Alternativ",
"ORDER": "Uppsättning",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "Order" (in the context of sorting) is "Uppsättning", which means "set" or "setup". The correct translation is "Ordning".

  "ORDER": "Ordning",

"PLAYLIST_CREATE_DIALOG_SUBTITLE": "Ange namn för spellistan",
"PLAYLIST_ADD_DIALOG_SUBTITLE": "Välj en spellista för att lägga till detta objekt",
"PLAYLIST_ADD_DIALOG_TITLE": "Lägg till i spellista",
"ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Now playing screen\" rippeleffekten",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The phrase "Now playing screen" is left untranslated. It should be translated for consistency with other keys like SHOW_NOW_PLAYING_SCREEN, which is translated as "Visa "Nu spelande"-skärmen".

  "ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Nu spelande\"-skärmens rippeleffekt",

"TAG_EDITOR_NO_TAGS_SUBTITLE": "Lägg till taggar för att organisera den här filen",
"TAG_EDITOR_NO_TAGS_TITLE": "Inga taggar hittades",
"TAG_EDITOR_REMOVE_COVER": "Ta bort omslaget",
"TAG_EDITOR_REMOVE_PROPERTY": "Ta bort fastighet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The word "fastighet" is used for "property", which is incorrect in this context. It should be "egenskap".

  "TAG_EDITOR_REMOVE_PROPERTY": "Ta bort egenskap",

"ENABLE_ANIMATION_EFFECTS": "Aktivera animationseffekter",
"ENABLE_DISCORD_RPC": "Aktivera Discord RPC",
"ENABLE_NOTIFICATION_LYRICS": "Aktivera meddelanden om låttexter",
"ENTRIES": "Entréer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "Entries" is "Entréer", which means "entrances". This is incorrect. A better translation would be "Inlägg" or "Poster". Since ENTRY is translated as "Inlägg", using "Inlägg" for the plural form maintains consistency.

  "ENTRIES": "Inlägg",

"PREVIOUS": "Föregående",
"PRIVACY": "Sekretess",
"PROCEED": "Fortsätt",
"PROPERTY": "Fastighet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "Property" is "Fastighet", which means "real estate". In the context of file metadata, the correct word is "Egenskap".

  "PROPERTY": "Egenskap",

index.json Outdated
Comment on lines 112 to 115
]



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are unnecessary trailing newlines at the end of the file. These should be removed to maintain a clean and consistent file format.

Suggested change
]
]

"MONO": "Mono",
"MORE": "Mer",
"MUTE": "Tyst",
"M_ALBUMS_AND_N_TRACKS": "\"M\" skivor & \"N\" spår",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The word "skivor" is used for "albums". To maintain consistency with other translations in the file, it would be better to use "album".

  "M_ALBUMS_AND_N_TRACKS": "\"M\" album & \"N\" spår",

"MENU": "Meny",
"MIX": "Blanda",
"MOBILE_ALBUM_GRID_SIZE": "Albumrutnätets storlek",
"MOBILE_ARTIST_GRID_SIZE": "Konstnärens rutnätstorlek",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The translation for "Artist" here is "Konstnär", which typically refers to a painter or visual artist. For a musician, "artist" is the more common and appropriate term in Swedish. A more natural compound word would be "Artistrutnätets storlek".

  "MOBILE_ARTIST_GRID_SIZE": "Artistrutnätets storlek",

"NOW_YOU_ARE_GOOD_TO_GO_BACK": "Nu är du redo att åka tillbaka.",
"NO_FOLDERS_ADDED": "Inga mappar har lagts till",
"NO_PLAYLISTS_FOUND": "Inga spellistor hittades.\nSkapa några för att se dem där.",
"N_ALBUMS": "\"N\" skivor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The word "skivor" is used for "albums". For consistency, it would be better to use "album".

  "N_ALBUMS": "\"N\" album",

"ADD_TO_NOW_PLAYING": "Lägg till nu spelande",
"ADD_TO_PLAYLIST": "Lägg till spellista",
"ALBUM": "Skiva",
"ALBUMS": "Skivor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The translation for "Albums" is "Skivor". For consistency with other translations in this file that use "album", I suggest changing this to "Album". The word "album" can be used for both singular and plural in this context in Swedish.

  "ALBUMS": "Album",

@alexmercerind
Copy link
Member

The checks are failing. I cannot merge unless you solve the issues.

@Vinyx08 Vinyx08 closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants