Skip to content

Conversation

@Vinyx08
Copy link

@Vinyx08 Vinyx08 commented Jan 10, 2026

No description provided.

SeliliPona and others added 30 commits January 9, 2026 00:03
translated strings added in snapshot
changed HIDE_LYRICS to match HIDE_HIDDEN_FILES
changed MORE to be more accurate
Updated Swedish localization strings for clarity and accuracy.
Updated Swedish localization strings for improved accuracy and clarity.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Vinyx08, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the application's internationalization by introducing comprehensive support for the Swedish language. This addition makes the application more accessible to Swedish-speaking users. Concurrently, it refines the existing Toki Pona localization, enhancing the overall quality and correctness of the translations for that language. These changes collectively contribute to a more inclusive and user-friendly experience for a diverse global audience.

Highlights

  • New Language Support: The Swedish language has been added to the application's localization, providing a full set of translations for the user interface.
  • Toki Pona Localization Improvements: Several existing Toki Pona localization strings have been updated and corrected for improved accuracy and clarity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds Swedish language support, which is a great contribution. The changes to README.md and tok.json look good. However, the new Swedish translation file, localizations/sv_SE.json, contains several issues that need to be addressed. There are critical JSON syntax errors due to incorrect indentation and extra characters, which will prevent the file from being parsed. Additionally, there are several translation inaccuracies that could confuse users. I've left detailed comments on each issue with suggestions for correction.

"OPTIONS": "Alternativ",
"ORDER": "Uppsättning",
"OTP": "Engångskod",
"OTP_SEND": "Skicka engångskod",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line has incorrect indentation (4 spaces instead of 2), which makes the JSON file invalid.

  "OTP_SEND": "Skicka engångskod",

"SETTINGS_SECTION_LASTFM_TITLE": "Last.fm",
"SETTINGS_SECTION_MEDIA_LIBRARY_SUBTITLE": "Konfigurera hur mediefilerna organiseras",
"SETTINGS_SECTION_MISCELLANEOUS_SUBTITLE": "Andra alternativ som kan konfigureras",
"SETTINGS_SECTION_NOW_PLAYING_SUBTITLE": "Konfigurera beteendet för \"Nu spelande\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line has incorrect indentation (4 spaces instead of 2), which makes the JSON file invalid.

Suggested change
"SETTINGS_SECTION_NOW_PLAYING_SUBTITLE": "Konfigurera beteendet för \"Nu spelande\"",
"SETTINGS_SECTION_NOW_PLAYING_SUBTITLE": "Konfigurera beteendet för \"Nu spelande\"",

"RESET_SPEED": "Återställ hastighet",
"RESTORE": "Återställ",
"RESTORE_DEFAULTS": "Återställ standardinställningar",
"RESULTS_FOR_QUERY": "Resultat för \"\"QUERY\"\",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is an extra comma at the end of the string value, before the closing quote. This is a syntax error and will cause the JSON to be unparseable.

Suggested change
"RESULTS_FOR_QUERY": "Resultat för \"\"QUERY\"\",
"RESULTS_FOR_QUERY": "Resultat för \"\"QUERY\"\"",

"PLAYING": "Spelar",
"PLAYLIST": "Spellista",
"PLAYLISTS": "Spellistor",
"PLAYLIST_DELETE_DIALOG_SUBTITLE": "Ta bort spellistan \"NAME\"\"?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is an extra double quote after the NAME placeholder, which makes this an invalid string and will cause JSON parsing to fail. It should be \"\"NAME\"\".

  "PLAYLIST_DELETE_DIALOG_SUBTITLE": "Ta bort spellistan \"\"NAME\"\"?",

"N_ALBUMS_ONE_TRACK": "\"N\" skivor & ett spår",
"N_ARTISTS": "\"N\" artister",
"N_CHANNELS": "\"N\" kanaler",
"N_ENTRIES": "\"N\" entréer",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "N_ENTRIES" is ""N" entréer". Similar to the comment for "ENTRIES", "entréer" means "entrances". This should be ""N" inlägg" to be correct and consistent with the translation of "ENTRY".

  "N_ENTRIES": "\"N\" inlägg",

"SUBSCRIPTION_EXPIRED_SUBTITLE": "Det gick inte att verifiera din åtkomst",
"SUBSCRIPTION_EXPIRED_TITLE": "Medlemskapet har löpt ut",
"TAG_EDITOR": "Taggredigerare",
"TAG_EDITOR_ADD_PROPERTY": "Lägg till fastighet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "property" here is "fastighet", which is incorrect in this context. It should be "egenskap".

Suggested change
"TAG_EDITOR_ADD_PROPERTY": "Lägg till fastighet",
"TAG_EDITOR_ADD_PROPERTY": "Lägg till egenskap",

"TAG_EDITOR_NO_TAGS_SUBTITLE": "Lägg till taggar för att organisera den här filen",
"TAG_EDITOR_NO_TAGS_TITLE": "Inga taggar hittades",
"TAG_EDITOR_REMOVE_COVER": "Ta bort omslaget",
"TAG_EDITOR_REMOVE_PROPERTY": "Ta bort fastighet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The translation for "property" here is "fastighet", which is incorrect in this context. It should be "egenskap".

Suggested change
"TAG_EDITOR_REMOVE_PROPERTY": "Ta bort fastighet",
"TAG_EDITOR_REMOVE_PROPERTY": "Ta bort egenskap",

"OPEN_FILE_OR_URL": "Öppna fil eller URL",
"OPEN_IN_BROWSER": "Öppna i webbläsare",
"OPTIONS": "Alternativ",
"ORDER": "Uppsättning",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The word "Uppsättning" is used for "ORDER". In the context of sorting, "Ordning" is the correct term. "Uppsättning" means "set" or "setup".

  "ORDER": "Ordning",

"PLAYLIST_CREATE_DIALOG_SUBTITLE": "Ange namn för spellistan",
"PLAYLIST_ADD_DIALOG_SUBTITLE": "Välj en spellista för att lägga till detta objekt",
"PLAYLIST_ADD_DIALOG_TITLE": "Lägg till i spellista",
"ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Now playing screen\" rippeleffekten",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "Now playing screen" is left untranslated in this string. For consistency with other translations (e.g., line 264, SHOW_NOW_PLAYING_SCREEN), it should be translated. A good translation would be "Nu spelande"-skärmens.

  "ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Nu spelande\"-skärmens rippeleffekt",

"MENU": "Meny",
"MIX": "Blanda",
"MOBILE_ALBUM_GRID_SIZE": "Albumrutnätets storlek",
"MOBILE_ARTIST_GRID_SIZE": "Konstnärens rutnätstorlek",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The translation for "MOBILE_ARTIST_GRID_SIZE" is "Konstnärens rutnätstorlek". "Konstnär" typically refers to a fine arts artist (like a painter), and it's in the singular genitive form ("the artist's"). For musicians, "artist" is the common word in Swedish. Since this is a grid of artists, a plural form would be more appropriate. A better translation would be "Artisters rutnätsstorlek", which is also consistent with ARTIST being translated as "Artist".

  "MOBILE_ARTIST_GRID_SIZE": "Artisters rutnätsstorlek",

@Vinyx08 Vinyx08 closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants