-
Notifications
You must be signed in to change notification settings - Fork 54
Add Swedish Language #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swedish Language #150
Conversation
translated strings added in snapshot changed HIDE_LYRICS to match HIDE_HIDDEN_FILES
changed MORE to be more accurate
Updated Swedish localization strings for clarity and accuracy.
Updated Swedish localization strings for improved accuracy and clarity.
Summary of ChangesHello @Vinyx08, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the application's internationalization by introducing comprehensive support for the Swedish language. This addition makes the application more accessible to Swedish-speaking users. Concurrently, it refines the existing Toki Pona localization, enhancing the overall quality and correctness of the translations for that language. These changes collectively contribute to a more inclusive and user-friendly experience for a diverse global audience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Swedish language support, which is a great contribution. The changes to README.md and tok.json look good. However, the new Swedish translation file, localizations/sv_SE.json, contains several issues that need to be addressed. There are critical JSON syntax errors due to incorrect indentation and extra characters, which will prevent the file from being parsed. Additionally, there are several translation inaccuracies that could confuse users. I've left detailed comments on each issue with suggestions for correction.
localizations/sv_SE.json
Outdated
| "OPTIONS": "Alternativ", | ||
| "ORDER": "Uppsättning", | ||
| "OTP": "Engångskod", | ||
| "OTP_SEND": "Skicka engångskod", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "SETTINGS_SECTION_LASTFM_TITLE": "Last.fm", | ||
| "SETTINGS_SECTION_MEDIA_LIBRARY_SUBTITLE": "Konfigurera hur mediefilerna organiseras", | ||
| "SETTINGS_SECTION_MISCELLANEOUS_SUBTITLE": "Andra alternativ som kan konfigureras", | ||
| "SETTINGS_SECTION_NOW_PLAYING_SUBTITLE": "Konfigurera beteendet för \"Nu spelande\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
localizations/sv_SE.json
Outdated
| "RESET_SPEED": "Återställ hastighet", | ||
| "RESTORE": "Återställ", | ||
| "RESTORE_DEFAULTS": "Återställ standardinställningar", | ||
| "RESULTS_FOR_QUERY": "Resultat för \"\"QUERY\"\", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "PLAYING": "Spelar", | ||
| "PLAYLIST": "Spellista", | ||
| "PLAYLISTS": "Spellistor", | ||
| "PLAYLIST_DELETE_DIALOG_SUBTITLE": "Ta bort spellistan \"NAME\"\"?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "N_ALBUMS_ONE_TRACK": "\"N\" skivor & ett spår", | ||
| "N_ARTISTS": "\"N\" artister", | ||
| "N_CHANNELS": "\"N\" kanaler", | ||
| "N_ENTRIES": "\"N\" entréer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "SUBSCRIPTION_EXPIRED_SUBTITLE": "Det gick inte att verifiera din åtkomst", | ||
| "SUBSCRIPTION_EXPIRED_TITLE": "Medlemskapet har löpt ut", | ||
| "TAG_EDITOR": "Taggredigerare", | ||
| "TAG_EDITOR_ADD_PROPERTY": "Lägg till fastighet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "TAG_EDITOR_NO_TAGS_SUBTITLE": "Lägg till taggar för att organisera den här filen", | ||
| "TAG_EDITOR_NO_TAGS_TITLE": "Inga taggar hittades", | ||
| "TAG_EDITOR_REMOVE_COVER": "Ta bort omslaget", | ||
| "TAG_EDITOR_REMOVE_PROPERTY": "Ta bort fastighet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "OPEN_FILE_OR_URL": "Öppna fil eller URL", | ||
| "OPEN_IN_BROWSER": "Öppna i webbläsare", | ||
| "OPTIONS": "Alternativ", | ||
| "ORDER": "Uppsättning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "PLAYLIST_CREATE_DIALOG_SUBTITLE": "Ange namn för spellistan", | ||
| "PLAYLIST_ADD_DIALOG_SUBTITLE": "Välj en spellista för att lägga till detta objekt", | ||
| "PLAYLIST_ADD_DIALOG_TITLE": "Lägg till i spellista", | ||
| "ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Now playing screen\" rippeleffekten", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase "Now playing screen" is left untranslated in this string. For consistency with other translations (e.g., line 264, SHOW_NOW_PLAYING_SCREEN), it should be translated. A good translation would be "Nu spelande"-skärmens.
"ENABLE_NOW_PLAYING_RIPPLE_EFFECT": "Aktivera \"Nu spelande\"-skärmens rippeleffekt",| "MENU": "Meny", | ||
| "MIX": "Blanda", | ||
| "MOBILE_ALBUM_GRID_SIZE": "Albumrutnätets storlek", | ||
| "MOBILE_ARTIST_GRID_SIZE": "Konstnärens rutnätstorlek", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation for "MOBILE_ARTIST_GRID_SIZE" is "Konstnärens rutnätstorlek". "Konstnär" typically refers to a fine arts artist (like a painter), and it's in the singular genitive form ("the artist's"). For musicians, "artist" is the common word in Swedish. Since this is a grid of artists, a plural form would be more appropriate. A better translation would be "Artisters rutnätsstorlek", which is also consistent with ARTIST being translated as "Artist".
"MOBILE_ARTIST_GRID_SIZE": "Artisters rutnätsstorlek",
No description provided.