Fix Docker tutorial build failing on fresh clone#1110
Open
jhf wants to merge 2 commits intohapostgres:mainfrom
Open
Fix Docker tutorial build failing on fresh clone#1110jhf wants to merge 2 commits intohapostgres:mainfrom
jhf wants to merge 2 commits intohapostgres:mainfrom
Conversation
Remove explicit COPY of git-version.h which doesn't exist in a fresh git clone. The file is generated by the Makefile when running make, so the explicit COPY was redundant and caused the build to fail. Fixes: hapostgres#1109 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Only run git commands to determine version when .git directory exists. When building in Docker or from a tarball without .git, the version is set to "unknown" instead of printing error messages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git-version.hwhich doesn't exist in a fresh git clone (the Makefile generates it automatically).gitdirectory before running git commands to avoid "fatal: not a git repository" warnings in Docker buildsFixes: #1109
Test plan
docker compose buildindocs/tutorialnow succeeds on fresh clone🤖 Generated with Claude Code