Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Conversation

@depfu
Copy link

@depfu depfu bot commented Jul 5, 2018


Welcome to Depfu πŸ‘‹

This is one of the first three pull requests with dependency updates we've sent your way. We tried to start with a few easy patch-level updates. Hopefully your tests will pass and you can merge this pull request without too much risk. This should give you an idea how Depfu works in general.

After you merge your first pull request, we'll send you a few more. We'll never open more than seven PRs at the same time so you're not getting overwhelmed with updates.

Let us know if you have any questions. Thanks so much for giving Depfu a try!


⚠️ No CI detected ⚠️

You don't seem to have any Continuous Integration service set up!

Without a service that will test the Depfu branches and pull requests, we can't inform you if incoming updates actually work with your app. We think that this degrades the service we're trying to provide down to a point where it is more or less meaningless.

This is fine if you just want to give Depfu a quick try. If you want to really let Depfu help you keep your app up-to-date, we recommend setting up a CI system:

  • Our friends at Travis-CI provide excellent service.
  • Circle CI are good, too, and have a free plan that will cover basic needs.
  • If you use something like Jenkins, make sure that you're using the Github integration correctly so that it reports status data back to Github.
  • If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with depfu/.

It might be necessary to once deactivate and reactivate your project in Depfu for the CI service to be properly detected.




🚨 Your version of nokogiri has known security vulnerabilities 🚨

Advisory: CVE-2018-8048
Disclosed: March 29, 2018
URL: https://github.com/sparklemotion/nokogiri/pull/1746

Revert libxml2 behavior in Nokogiri gem that could cause XSS

[MRI] Behavior in libxml2 has been reverted which caused
CVE-2018-8048 (loofah gem), CVE-2018-3740 (sanitize gem), and
CVE-2018-3741 (rails-html-sanitizer gem). The commit in question is
here:

GNOME/libxml2@960f0e2

and more information is available about this commit and its impact
here:

flavorjones/loofah#144

This release simply reverts the libxml2 commit in question to protect
users of Nokogiri's vendored libraries from similar vulnerabilities.

If you're offended by what happened here, I'd kindly ask that you
comment on the upstream bug report here:

https://bugzilla.gnome.org/show_bug.cgi?id=769760


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

We've updated a dependency and here is what you need to know:

name version specification old version new version
nokogiri indirect dependency 1.6.6.2 1.8.4

To resolve a dependency conflict, the update changed a few other dependencies as well:

action name old version new version
added concurrent-ruby 1.0.5
added crass 1.0.4
added mini_portile2 2.3.0
removed mini_portile 0.6.2
updated builder 3.2.2 3.2.3
updated i18n 0.7.0 0.9.5
updated jquery-rails 4.0.4 4.0.5
updated json 1.8.3 1.8.6
updated loofah 2.0.2 2.2.2
updated minitest 5.7.0 5.11.3
updated rack 1.6.4 1.6.10
updated rails-dom-testing 1.0.6 1.0.9
updated rails-html-sanitizer 1.0.2 1.0.4
updated rake 10.4.2 12.3.1
updated thor 0.19.1 0.20.0
updated thread_safe 0.3.5 0.3.6
updated tzinfo 1.2.2 1.2.5

You should probably take a good look at the info here and the test results before merging this pull request, of course.

What changed?

↗️ nokogiri (indirect, 1.6.6.2 β†’ 1.8.4) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ builder (indirect, 3.2.2 β†’ 3.2.3) Β· Repo Β· Changelog

↗️ i18n (indirect, 0.7.0 β†’ 0.9.5) Β· Repo Β· Changelog

Release Notes

From the Github release:

  • #404 reported a regression in 0.9.3, which wasn't fixed by 0.9.4. #408 fixes this issue.

Thanks @wjordan!

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ jquery-rails (4.0.4 β†’ 4.0.5) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ json (indirect, 1.8.3 β†’ 1.8.6) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 31 commits:

↗️ loofah (indirect, 2.0.2 β†’ 2.2.2) Β· Repo Β· Changelog

Release Notes

From the Github release:

2.2.2 / 2018-03-22

Make public Loofah::HTML5::Scrub.force_correct_attribute_escaping!,
which was previously a private method. This is so that downstream gems
(like rails-html-sanitizer) can use this logic directly for their own
attribute scrubbers should they need to address CVE-2018-8048.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.7.0 β†’ 5.11.3) Β· Repo Β· Changelog

↗️ rack (indirect, 1.6.4 β†’ 1.6.10) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by 26 commits:

↗️ rails-dom-testing (indirect, 1.0.6 β†’ 1.0.9) Β· Repo

Commits

See the full diff on Github. The new version differs by 19 commits:

↗️ rails-html-sanitizer (indirect, 1.0.2 β†’ 1.0.4) Β· Repo Β· Changelog

Release Notes

From the Github release:

Commits

See the full diff on Github. The new version differs by 27 commits:

↗️ rake (indirect, 10.4.2 β†’ 12.3.1) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ thor (indirect, 0.19.1 β†’ 0.20.0) Β· Repo Β· Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ thread_safe (indirect, 0.3.5 β†’ 0.3.6) Β· Repo

Commits

See the full diff on Github. The new version differs by 20 commits:

↗️ tzinfo (indirect, 1.2.2 β†’ 1.2.5) Β· Repo Β· Changelog

Release Notes

From the Github release:

  • Support recursively (deep) freezing Country and Timezone instances. #80.
  • Allow negative daylight savings time offsets to be derived when reading from zoneinfo files. The utc_offset and std_offset are now derived correctly for Europe/Dublin in the 2018a and 2018b releases of the Time Zone Database.

TZInfo v1.2.5 on RubyGems.org

Commits

See the full diff on Github. The new version differs by 47 commits:


Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

Depfu Status

@depfu depfu bot added the depfu label Jul 5, 2018
@depfu
Copy link
Author

depfu bot commented Oct 5, 2018

Closed in favor of #24.


Automated by Depfu.

@depfu depfu bot closed this Oct 5, 2018
@depfu depfu bot deleted the depfu/update/nokogiri-1.8.4 branch October 5, 2018 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants