feat: move project to Swift Package Manager, update to SDK 9.4.0#151
Open
hansemannn wants to merge 4 commits intomainfrom
Open
feat: move project to Swift Package Manager, update to SDK 9.4.0#151hansemannn wants to merge 4 commits intomainfrom
hansemannn wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the module to Swift Package Manager and updates the SDK to version 9.4.0 while removing legacy Git LFS–managed header files.
- Removed Git LFS pointer metadata files for various Google Maps headers as they are no longer needed.
- Introduced the new hooks/ti.spm.js file with an injectSPMPackage function to integrate Swift Package Manager dependencies into the Xcode project.
Reviewed Changes
Copilot reviewed 850 out of 858 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| platform/GoogleMaps.xcframework/ios-arm64/GoogleMaps.framework/Headers/*.h | Removed Git LFS pointer files for legacy dependency management. |
| hooks/ti.spm.js | Added new hook for injecting Swift Package Manager dependencies. |
Files not reviewed (8)
- Cartfile: Language not supported
- Cartfile.resolved: Language not supported
- Classes/TiGooglemapsModule.m: Language not supported
- Classes/TiGooglemapsView.m: Language not supported
- Resources/GooglePlaces.bundle/PrivacyInfo.xcprivacy: Language not supported
- manifest: Language not supported
- platform/GoogleMaps.xcframework/Info.plist: Language not supported
- platform/GoogleMaps.xcframework/ios-arm64/GoogleMaps.framework/GoogleMaps: Language not supported
Comments suppressed due to low confidence (1)
hooks/ti.spm.js:64
- [nitpick] Confirm that the string concatenation for packageProductDependencies adheres to the pbxproj format. If a structured array format is supported, using that might improve readability and maintainability.
nativeTarget["packageProductDependencies"] = "(\n\t\t\t\t" + swiftProductUUID + " /* " + swiftPackageProductName + " */,\n\t\t\t)";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
ti.googlemapsmodule, including dependency updates, feature enhancements, deprecations, and privacy compliance improvements. The changes modernize the module by upgrading dependencies, improving compatibility with newer iOS versions, and adding support for Swift Package Manager (SPM). Below is a summary of the most significant changes:Dependency and Compatibility Updates:
CartfileandCartfile.resolvedto transition to Swift Package Manager for dependency management. [1] [2]manifestfile. [1] [2]Feature Enhancements:
injectSPMPackagefunction inhooks/ti.spm.jsto integrate Swift Package Manager dependencies into the Xcode project, replacing the previous manual binary integration.TiGooglemapsView.mto useGMSMapViewOptionsfor better configuration flexibility, including setting a default background color.Deprecations and Warnings:
enableMetalRenderermethod inTiGooglemapsModule.mwith a warning message, as Metal is now the default renderer.Privacy Compliance:
PrivacyInfo.xcprivacyfile to theGooglePlaces.bundle, detailing data collection and usage practices for compliance with Apple's privacy guidelines.