Conversation
bench/bench_csharp_preview.yaml
Outdated
| # - /tmp/.nuget/packages:/root/.nuget/packages | ||
| include: dotnet_preview | ||
| build: dotnet publish -c Release -r linux-x64 -f net7 --self-contained true -p:PublishSingleFile=true -o out # -p:PublishReadyToRun=true | ||
| build: dotnet publish -c Release -r linux-x64 -f net8 --self-contained true -p:PublishSingleFile=true -o out # -p:PublishReadyToRun=true |
There was a problem hiding this comment.
we could target net7 just as well, but bench\include\dotnet_preview\app.csproj targets net8 so I had to change one or the other.
| sudo apt-add-repository https://packages.microsoft.com/ubuntu/22.04/prod | ||
| sudo apt-get update | ||
| sudo apt-get install -y libmsquic zlib1g-dev | ||
| sudo apt-get install -y libmsquic zlib1g-dev clang |
There was a problem hiding this comment.
haven't validated this is sufficient to get nativeaot to build in the container. if necessary we can remove it from bench.yml for now as the other changes should be fine.
|
@hanabi1224 could you unblock the validation workflow maybe? no hurry though :) |
hanabi1224
force-pushed
the
main
branch
3 times, most recently
from
3fc55d3 to
d70acc7
Compare
bench/bench_csharp_preview.yaml
Outdated
| @@ -73,10 +77,10 @@ environments: | |||
| compiler: dotnet | |||
| version: 7 | |||
There was a problem hiding this comment.
possibly this should be 8 too, but I guess it works.
|
The tests timed out after 5 hours but the log only showed a couple mins of run time... |
|
@hanabi1224 I think it needs your okay again. |
|
@hanabi1224 ? 😀 |
|
@hanabi1224 would it be possible to have a look? I see you already updated to 10, but this enables more tests. |
- Add clang dependency to .github/dotnet.sh for NativeAOT support - Add csharp_preview and csharp_native_aot to bench.yml workflow - Add unzip requirement to README.md - Add multiproc regex-redux files (5-m.cs, 6-m.cs) to bench configs - Fix lang field in bench_csharp_native_aot.yaml - Enable and uncomment scenarios in bench_csharp_preview.yaml - Fix ProcFs naming convention (procfs → ProcFs) for consistency Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
|
superseded -- still want #499 merged though, .NET 10 was released last Nov. |
2 participants
enable numbers for preview and nativeaot
change preview to actually use preview docker image
add necessary nativeaot dependency to image (clang)
minor readme updates
uncomment scenarios for preview
add multiproc versions of regex-redux so we get both sets of numbers
Note: I haven't got bench.yml to work locally so I haven't verified that clang is all that's needed for nativeaot.