Skip to content

Update secretName field in policy template#48

Merged
f2c-ci-robot[bot] merged 1 commit intohalo-sigs:mainfrom
ruibaby:refactor/username-password
Jan 16, 2026
Merged

Update secretName field in policy template#48
f2c-ci-robot[bot] merged 1 commit intohalo-sigs:mainfrom
ruibaby:refactor/username-password

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 16, 2026

Fixes #23

image image
优化用户名/密码表单类型,适配 Halo 2.22.10

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 16, 2026
@ruibaby ruibaby requested a review from JohnNiang January 16, 2026 10:54
Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是否需要限制插件要求最低 Halo 版本为 2.22.10?

@ruibaby
Copy link
Member Author

ruibaby commented Jan 16, 2026

这里是否需要限制插件要求最低 Halo 版本为 2.22.10?

只看配置层面是不需要的,在低版本 Halo 下顶多没有提示所需字段。如果所需字段提示很重要的话可以提升到 2.22.10

Copy link
Contributor

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@f2c-ci-robot f2c-ci-robot bot merged commit 0c114ff into halo-sigs:main Jan 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

添加用户名和密码

2 participants

Comments