This repository was archived by the owner on Dec 24, 2018. It is now read-only.
Open
Conversation
Small change to executable takes into account directory structure changes at nodejs.org for versions greater than 4. If the version being installed is greater than 4 then the request directory is changed accordingly by adding win-x64 or win-x86 to NODE_EXE_URL variable. This removes 404 error for node versions greater than 4.
|
Hi this would be really useful to have merged. Any update on when this will happen @hakobera ?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to nvmw.bat takes into account directory structure changes at nodejs.org for versions greater than 4.
If the version being installed is greater than 4 then the request directory is changed accordingly by adding win-x64 or win-x86 to NODE_EXE_URL variable. This removes 404 error for node versions greater than 4.