Skip to content
This repository was archived by the owner on Dec 24, 2018. It is now read-only.

Comments

Fixes the issue of not downloading from the right URL for newer versions of Node.#62

Closed
snlacks wants to merge 3 commits intohakobera:masterfrom
snlacks:master
Closed

Fixes the issue of not downloading from the right URL for newer versions of Node.#62
snlacks wants to merge 3 commits intohakobera:masterfrom
snlacks:master

Conversation

@snlacks
Copy link

@snlacks snlacks commented Sep 28, 2015

Still works on older versions. I think this addresses: #61 #60 #58 #59 #57

Tested installs for x64 latest, 0.12.7, 4.1.1

Thanks for the awesome tool!

@TimothyGu
Copy link

Duplicate of #59.

@snlacks
Copy link
Author

snlacks commented Sep 29, 2015

Thank you TimothyGu, I thought 59 was the same issue. Fixing the prefix didn't fix downloading new versions, <4 follows has a different path. This addresses the 404 on attempts to download versions on the new path and still works on the older versions.

@yuu2lee4
Copy link

how to update my local nvmw?

@snlacks
Copy link
Author

snlacks commented Oct 11, 2015

I haven't tested it since the last commit, but if you want to use my fork you can change my user name out for hakobera like this:

git clone git://github.com/snlacks/nvmw.git "%HOMEDRIVE%%HOMEPATH%.nvmw"

But, I don't know if it still works or if anyone else tested it. I don't really recommend this, there's other open issues with nvmw as well. This fix doesn't fix the path to the version installed and checks for iojs v. node in a way that doesn't result in the right one. nvm-windows was updated more recently, https://github.com/coreybutler/nvm-windows

@TimothyGu
Copy link

But, I don't know if it still works or if anyone else tested it.

As this is very similar to my PR #59 at 04fbbdf, I can say that it works partially: installing Node.js/io.js works fine but installing npm only works after one try. The two other commits in #59: a710272 and 4234f62 address the npm installation issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants