[Login] Backfill referral_link_id
#12389
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| class BackfillLinkIdOnLogin < ApplicationJob | ||
| def perform | ||
| Login.where.not(referral_program_id: nil).find_each do |login| | ||
| login.update!(referral_link_id: login.referral_program.links.first.id) |
There was a problem hiding this comment.
Bug: The backfill job can crash with a NoMethodError by calling .id on login.referral_program.links.first when a program has no associated links, resulting in nil.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The backfill job at app/jobs/one_time_jobs/backfill_link_id_on_login.rb updates a login record using login.referral_program.links.first.id. However, a Referral::Program can exist without any associated Referral::Link objects, especially for programs created before the link functionality was added. When a program has no links, links.first returns nil. Calling .id on nil raises a NoMethodError, which will crash the entire backfill job because it lacks error handling for this case, leaving the data migration incomplete.
💡 Suggested Fix
Use safe navigation (&.) to prevent the error when no link is found. Update the line to login.update!(referral_link_id: login.referral_program.links.first&.id). This will safely assign nil to referral_link_id if no link exists, preventing the job from crashing.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: app/jobs/one_time_jobs/backfill_link_id_on_login.rb#L7
Potential issue: The backfill job at
`app/jobs/one_time_jobs/backfill_link_id_on_login.rb` updates a `login` record using
`login.referral_program.links.first.id`. However, a `Referral::Program` can exist
without any associated `Referral::Link` objects, especially for programs created before
the link functionality was added. When a program has no links, `links.first` returns
`nil`. Calling `.id` on `nil` raises a `NoMethodError`, which will crash the entire
backfill job because it lacks error handling for this case, leaving the data migration
incomplete.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7234613
There was a problem hiding this comment.
All programs have a link right now so this should be fine.
Summary of the problem
This is the prerequisite to dropping
logins.referral_program_idDescribe your changes