Simplify #48
Open
Simplify #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more free monad for every JDBC method, instead just a simple one for `ConnectionIO`. No more `fs2` support. There is no reason to stream results from a database. If the result is small enough then use a collection. If it is too large then do multiple database calls using cursor pagination on the tables primary key. This means that the core module no longer depends on `cats-effect` or `fs2`. Also no more support for testing libraries that have test methods that return `Unit`. Use a testing library that requires tests return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more free monad for every JDBC method, instead just a simple one for
ConnectionIO.No more
fs2support. There is no reason to stream results from a database. If the result is small enough then use a collection. If it is too large then do multiple database calls using cursor pagination on the tables primary key.The result of this means that the core module no longer depends on
cats-effectorfs2.Also no more support for testing libraries that have test methods that return
Unit. Use a testing library that requires tests return a value.