Loop through records from SQS #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellenmuller
changed the title
joelochlann
reviewed
Jan 27, 2026
joelochlann
reviewed
Jan 27, 2026
joelochlann
reviewed
Jan 27, 2026
joelochlann
reviewed
Jan 27, 2026
| case Tiff => Left("Image file type is not supported. File type: Tiff") | ||
| } | ||
| } | ||
| object EmbedderMessage { |
joelochlann
reviewed
Jan 27, 2026
ellenmuller
force-pushed
the
em-lambda-fix
branch
2 times, most recently
from
1e90bf8 to
89cb191
Compare
joelochlann
reviewed
Jan 28, 2026
| @@ -0,0 +1,43 @@ | |||
| #!/bin/bash | |||
| set -euo pipefail | |||
Member
There was a problem hiding this comment.
think it's worth a note (comment?) about what this does! sends a batch containing the same message 10 times?
Contributor
Author
There was a problem hiding this comment.
Yeah fair enough - I added something in the PR description so I'll add that as a comment
|
Seen on metadata-editor (merged by @ellenmuller 8 minutes and 54 seconds ago) Please check your changes! |
|
Seen on auth, usage, image-loader, cropper, collections, kahuna (merged by @ellenmuller 8 minutes and 59 seconds ago) Please check your changes! |
|
Seen on thrall, leases, media-api (merged by @ellenmuller 9 minutes and 5 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR actions some comments from my previous PR, #4593, most notably this one #4593 (comment).
We now loop through the records sent from SQS, and if there's an error they get captured as
BatchItemFailuresand returned at the end of the handler. This is to avoid an error happening halfway through the loop, and the whole batch ending on the DLQ. This is recommended by AWS here https://docs.aws.amazon.com/prescriptive-guidance/latest/lambda-event-filtering-partial-batch-responses-for-sqs/best-practices-partial-batch-responses.html.I've also added a script to send a batch of records and we can see that the handler correctly loops through them. (Do note that the write to the S3 Vector Store will fail because we're trying to write duplicate keys! This script is just useful for testing the loop behaviour and perhaps may be useful in the future if we start skipping images already embedded)
I also added a case class
EmbedderMessagefor themessageBodywe send to SQS from image-loader for extra type safety.