Fixes FileMetadataReaderTest fails locally during British summer #4561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoving non time zoned date formatter which was shadowing the long standing time zoned date formatter.
Add a British summer time YYYY-MM-dd example to show that this formatter is locale dependant.
DateTimeFormat.forPattern("yyyy-MM-dd") matches the same pattern as ISODateTimeFormat.date.withZoneUTC but removes the withZoneUTC behaviour.
I do not know if that was intentional but FileMetadataReaderTest was a long standing test so this could be considered a regression.
Additionally, that entire block of date formatters probably have an indeterminate outcome.
tonytw1
commented
Nov 15, 2025
| DateTimeFormat.forPattern("yyyy"), | ||
| DateTimeFormat.forPattern("yyyy-MM"), | ||
| DateTimeFormat.forPattern("yyyy:MM:dd"), | ||
| DateTimeFormat.forPattern("yyyy-MM-dd"), |
Contributor
Author
There was a problem hiding this comment.
Over shadows the UTC timezoned version on line 157?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a local machine (local
LC_TIME="en_GB.UTF-8")FileMetadataReaderTesttests fail occasionally (probably seasonly)Fixed by removing a more recent non time zoned date formatter which was shadowing the long standing time zoned date formatter.
Might just be my machine, but the shadowed formatter might be interesting to others.
DateTimeFormat.forPattern("yyyy-MM-dd") matches the same pattern as ISODateTimeFormat.date.withZoneUTC but removes the withZoneUTC behaviour.
Add a British summer time YYYY-MM-dd example to show that this formatter is locale dependant.
I do not know if that was intentional but FileMetadataReaderTest was a long standing test so this could be considered a regression.
Additionally, that entire block of date formatters probably have an indeterminate outcome.
What does this change?
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?