Open
Conversation
Collaborator
|
very nice description |
CDEguia
requested changes
Mar 14, 2024
Collaborator
CDEguia
left a comment
CDEguia
left a comment
There was a problem hiding this comment.
As is, the healthcheck is not being applied to any service. Please indent the healthcheck and it parameter so it get's applied to a service.
P.S. was this tested as is?
Comment on lines
+44
to
+51
|
|
||
| #This can help Docker automatically handle container failures and restart unhealthy containers. | ||
| healthcheck: | ||
| test: ["CMD-SHELL", "curl -f http://localhost/ || exit 1"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 3 | ||
| start_period: 60s No newline at end of file |
Collaborator
There was a problem hiding this comment.
indentaion level is as if it is a service. To apply this heathcheck to a service it must me indented just like image or environmnet is. The suggested code change below would apply the health check to the app2 service
Suggested change
| #This can help Docker automatically handle container failures and restart unhealthy containers. | |
| healthcheck: | |
| test: ["CMD-SHELL", "curl -f http://localhost/ || exit 1"] | |
| interval: 30s | |
| timeout: 10s | |
| retries: 3 | |
| start_period: 60s | |
| # This can help Docker automatically handle container failures and restart unhealthy containers. | |
| healthcheck: | |
| test: ["CMD-SHELL", "curl -f http://localhost/ || exit 1"] | |
| interval: 30s | |
| timeout: 10s | |
| retries: 3 | |
| start_period: 60s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a health check on the docker-compose.yml file. This makes sure container remains healthy by periodocally checking if makes an HTTP request to localhost. If it fails it tries 3 more times before considering container .