Skip to content

Conversation

@jeanparpaillon
Copy link

Add support for Ecto 3.x

Jean Parpaillon and others added 2 commits June 27, 2019 15:40
@hickscorp
Copy link

@jeanparpaillon Any idea why the PR is failing the tests?

@jeanparpaillon
Copy link
Author

@hickscorp you're calling __using__ macro... from inside __using__ macro, hence the error
For providing default implementations of behaviours, look at GenServer code from elixir lib (play with defoverridable and such)

@hickscorp
Copy link

hickscorp commented Sep 30, 2019

@jeanparpaillon Should we use @behaviour Ecto.Type and add as_embed and equals? here instead then? Otherwise, your addition @behaviour Ecto.Type breaks specs.

@jeanparpaillon
Copy link
Author

As long as there is a generic implementation of as_embed and equals? for EctoPoly, you can write it in the __using__/1 macro.

@hickscorp
Copy link

hickscorp commented Oct 19, 2020

This package breaks with recent versions of Ecto. I'm not entirely sure how to manage the issue, as the package seems to have no activity any more. Any suggestion on a replacement?

See #4 for the recent breakage with Ecto 3.5.2.

@hickscorp
Copy link

hickscorp commented Oct 19, 2020

@jeanparpaillon I've written the changes needed to become compatible with Ecto 3.5 while trying to remain backward-compatible.
This package seems to be abandoned - would you like us to rename it and host it on hex?
@greenboxal any chance you can pick up on that please?

@hickscorp hickscorp force-pushed the ecto-3.x branch 2 times, most recently from 89c0819 to 73ea5d3 Compare October 19, 2020 14:55
@hickscorp hickscorp mentioned this pull request Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants