Stop service and remove notification if process stops.#101
Stop service and remove notification if process stops.#101caiofaustino wants to merge 3 commits intogreenaddress:masterfrom
Conversation
caiofaustino
force-pushed
the
clear-notification
branch
from
fc954dc to
dc1b102
Compare
udiWertheimer
left a comment
udiWertheimer
left a comment
There was a problem hiding this comment.
Tested ACK dc1b102
Thanks for this pull request @caiofaustino!
Just a thought, and this doesn't have to be part of this pull request, but if you feel like it, it might also make sense to make sure the UI switch for starting ABCore is set to false when running onDestroy
yeah I'm planning on doing another PR to work on the UI switch logic a bit |
| public void run() { | ||
| try { | ||
| final int exit = mProcessTor.waitFor(); | ||
| Log.i(TAG, "Bitcoin process finished - " + exit); |
There was a problem hiding this comment.
log line should say Tor process finished
| Log.i(TAG, "Bitcoin process finished - " + exit); | ||
| stopSelf(); | ||
| } catch (InterruptedException e) { | ||
| Log.e(TAG, "Bitcoin InterruptedException", e); |
caiofaustino
force-pushed
the
clear-notification
branch
from
dc1b102 to
8bd889a
Compare
|
Fixed logs and renamed mProcess to mBitcoinProcess for clarity. |
|
This breaks start on a vanilla install for me - immediately dies, without this it doesn't |
|
What dies? The service and the notification? Can you share any logs? I'll investigate more. |
caiofaustino
force-pushed
the
clear-notification
branch
from
8bd889a to
957cf53
Compare
caiofaustino
force-pushed
the
clear-notification
branch
from
0c0ede4 to
c365b7e
Compare
|
I'll wait on #106 so that I can do some more testings. |
|
I'm closing this until I finish testing other issues I found that relate to this. |
4 participants
No description provided.