-
Notifications
You must be signed in to change notification settings - Fork 68
RP2040 driver changes to support the FlexiHAL2350 and FlexGPIO expander #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
terjeio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest core and the driver has changes that requires changes to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change configs not related to adding the new code.
| #if DRIVER_SPINDLE_ENABLE & SPINDLE_DIR | ||
| #define SPINDLE_DIRECTION_PIN 12 //RP2040 pin | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now moved the RESET/FEED_HOLD/CYCLE_START pin definitions to aux inputs and claim them from there if enabled.
|
|
||
| //#define AUXINPUT9_PIN 8 // I2C strobe pin | ||
|
|
||
| #if PROBE_ENABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI new in the latest commit is that two additional probe inputs are supported. These can be claimed explicitly by assigning to a given pin or from unclaimed pins.
| #include "ws2812.pio.h" | ||
|
|
||
| #define AUX_DEVICES // until all drivers are converted? | ||
| //#define AUX_DEVICES // until all drivers are converted? **AM Could not get the board to properly enumerate the ports without removing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This define has been removed and associated code has been permanently enabled. Enumeration failed completely if not commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only add the new stuff and leave it commented out...
I put the FlexGPIO in its own plugin repo instead of in the driver code (like the other I2C expanders) as it is fairly generic and could be used on other boards pretty easily.
I did find I had to extend some of the arrays in the xbar to support the additional aux io ports. And I hope I used the new API correctly to assign and enumerate the ports.
Plugin repo is here:
https://github.com/Expatria-Technologies/plugin_FlexGPIO
Actual expander code repo is here:
https://github.com/Expatria-Technologies/FlexGPIO
Board schematics (repo and readme are WIP):
FLEXI_HAL_PRO_Schematic_A3_FULL_PLACE.PDF
https://github.com/Expatria-Technologies/FlexiHAL_2350