fix issue with grabing volume of mono sources and sinks #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graysky2
force-pushed
the
master
branch
2 times, most recently
from
6242df0 to
4115a1c
Compare
imustafin
reviewed
Feb 27, 2020
There was a problem hiding this comment.
I just wanted to send a similar PR :)
@jackinloadup @graysky2 indeed this should fix #52 and that issue is a real problem.
My headset is mono and I have a similar problem to #52.
My headset has no Front {Left, Right} channels and has only Mono channel:
* index: 2
name: <alsa_output.usb-Razer_Razer_Nari-00.mono-fallback>
driver: <module-alsa-card.c>
flags: HARDWARE HW_MUTE_CTRL DECIBEL_VOLUME LATENCY DYNAMIC_LATENCY
state: RUNNING
suspend cause: (none)
priority: 9040
volume: mono: 25658 / 39% / -24.44 dB
balance 0.00
base volume: 65536 / 100% / 0.00 dB
volume steps: 65537
Compared to stereo
index: 1
name: <alsa_output.pci-0000_00_1f.3.analog-stereo>
driver: <module-alsa-card.c>
flags: HARDWARE HW_MUTE_CTRL HW_VOLUME_CTRL DECIBEL_VOLUME LATENCY DYNAMIC_LATENCY
state: SUSPENDED
suspend cause: IDLE
priority: 9039
volume: front-left: 30419 / 46% / -20.00 dB, front-right: 30419 / 46% / -20.00 dB
balance 0.00
Thus this PR should fix the problem.
graysky2
force-pushed
the
master
branch
3 times, most recently
from
bb1dbd9 to
1eb2a0c
Compare
Open
Correct awk expression Co-authored-by: Ilgiz Mustafin <imustafin@users.noreply.github.com>
Author
|
Apologies for the hiatus. Please comment if this issue is still relevant and I'll put in the time to resolve the conflict and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #52 I believe