This repository was archived by the owner on Sep 2, 2020. It is now read-only.
Support code-completing default values for variables#246
Open
shadaj wants to merge 6 commits intographql:masterfrom
apollographql:master
Open
Support code-completing default values for variables#246shadaj wants to merge 6 commits intographql:masterfrom apollographql:master
shadaj wants to merge 6 commits intographql:masterfrom
apollographql:master
Conversation
The test didn't pass after rebasing on top of the lastest upstream, and I'd like us to take the time to see if we can find a cleaner solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the code-completion logic, this includes a fix to the parser to always surface types to the first non-type parent state, which is required to have access to the variable type when searching for completion candidates for the default value.