Conversation
Summary of ChangesHello @mskorokhodov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request transitions the GraphQL gateway's interactive development environment from GraphiQL to Hive Lab. This enhancement provides users with an updated and potentially more feature-rich interface for interacting with the GraphQL API, improving the developer experience by leveraging the new rendering capabilities. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request switches the default GraphQL IDE from GraphiQL to Hive Laboratory. The implementation in packages/gateway/src/cli.ts is well-done, preserving backward compatibility by reassigning the renderGraphiQL default option. However, the new dependency in packages/gateway/package.json uses a local file path, which will cause issues in CI/CD environments and for other developers. I've added a comment to address this.
packages/gateway/package.json
Outdated
| "@graphql-tools/load": "^8.1.6", | ||
| "@graphql-tools/utils": "^11.0.0", | ||
| "@graphql-yoga/render-graphiql": "^5.16.2", | ||
| "@graphql-yoga/render-laboratory": "../../../graphql-yoga/packages/render-laboratory", |
There was a problem hiding this comment.
This dependency uses a local file path, which is not suitable for a package intended for publication. It will cause installation failures for anyone who doesn't have the graphql-yoga repository at the same relative path. Please replace this with a version from a package registry (like npm) or use a workspace reference (e.g., workspace:*) if this package is part of the same monorepo.
d7ec4a8 to
c6045c6
Compare
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/gateway |
2.4.3-alpha-b8d008330c45653cf6e40e27d1e7bda618532c1f |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
2.0.40-alpha-b8d008330c45653cf6e40e27d1e7bda618532c1f |
npm ↗︎ unpkg ↗︎ |
No description provided.