Potential fixes for 2 code quality findings

[ardatan]

This PR applies 2/2 suggestions from code quality AI findings.

[gemini-code-assist]

Summary of Changes

Hello @ardatan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements two targeted code quality improvements identified by AI findings. It refines object construction logic to ensure optional properties are only included when they have a defined value, and addresses a minor spelling error in a log message for enhanced clarity.

Highlights

• Conditional Property Assignment: The upLink property is now conditionally added to the configuration object only if its value is defined, preventing the assignment of undefined.
• Typo Correction: A spelling error in a log message was corrected, changing 'successfuly' to 'successfully'.

Changelog

• packages/gateway/src/commands/supergraph.ts
  • Ensured the upLink property is only added to the configuration object if its value is defined, preventing undefined from being explicitly set.
  • Corrected a spelling mistake from 'successfuly' to 'successfully' in a supergraph watcher log message.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[theguild-bot]

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package	Version	Info
@graphql-hive/router-runtime	1.1.12-alpha-42bcd30181b05f85e982f783645d2707c39dba96	npm ↗︎ unpkg ↗︎

[gemini-code-assist]

Code Review

The pull request addresses two code quality findings. The first change correctly conditionally adds the upLink property to the supergraph object, preventing it from being undefined when not provided. The second change fixes a typo in a log message, changing "successfuly" to "successfully". Both changes improve code robustness and readability.