Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by the Changesets release action, prepares for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This PR updates the Hive Console deployment to version 9.5.0, including changes to the docker-compose file download links, docker tag, and related documentation. It also removes a now-obsolete changeset file and adds a Cargo.lock file to .gitignore. The most significant change is the addition of experimental support for running without the supertokens service, requiring updates to environment variables and docker-compose configurations. I have added a comment to address a potential issue with the wget/curl links in the documentation.
|
|
||
| ```sh | ||
| curl -O https://raw.githubusercontent.com/graphql-hive/console/hive@9.4.1/docker/docker-compose.community.yml | ||
| curl -O https://raw.githubusercontent.com/graphql-hive/console/hive@9.5.0/docker/docker-compose.community.yml |
There was a problem hiding this comment.
The wget and curl commands are downloading the docker-compose file directly from the hive branch. If the intention is to download a stable version, it would be better to use the main branch or a specific tag to avoid unexpected changes. Using the main branch ensures users always get the latest stable version, while using a specific tag ensures reproducibility.
Consider updating the URL to point to main or a specific release tag.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7727.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
293592f to
fd1aef1
Compare
6157862 to
cefdb60
Compare
b86da15 to
3567483
Compare
9d9cea2 to
81cdc23
Compare
f574fff to
c10e02e
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
hive@9.5.0
Minor Changes
#7699
5f88ce8Thanks @n1ru4l! - Add experimental support for running without
supertokensservice.Instructions
Prerequisites
Adjust your docker compose file like the following:
services.supertokensfrom yourdocker-compose.community.ymlfileservices.server.environmentSUPERTOKENS_CONNECTION_URI=SUPERTOKENS_API_KEY=services.server.environmentSUPERTOKENS_AT_HOME=1SUPERTOKENS_REFRESH_TOKEN_KEY=SUPERTOKENS_ACCESS_TOKEN_KEY=services.migrations.environmentSUPERTOKENS_AT_HOME=1Set the refresh token key
Extract from existing
supertokensdeploymentThis method works if you use supertokens before and want to have existing user sessions to
continue working. If you want to avoid messing with the database, you can also create a new
refresh token key from scratch, the drawback is that users are forced to login again.
Extract the refresh token key from the supertokens database
The key should look similar to this:
1000:15e5968d52a9a48921c1c63d88145441a8099b4a44248809a5e1e733411b3eeb80d87a6e10d3390468c222f6a91fef3427f8afc8b91ea1820ab10c7dfd54a268:39f72164821e08edd6ace99f3bd4e387f45fa4221fe3cd80ecfee614850bc5d647ac2fddc14462a00647fff78c22e8d01bc306a91294f5b889a90ba891bf0aa0Update the docker compose
services.server.environment.SUPERTOKENS_REFRESH_TOKEN_KEYenvironmentvariable value to this string.
Create from scratch
Run the following command to create a new refresh key from scratch:
Update the docker compose
services.server.environment.SUPERTOKENS_REFRESH_TOKEN_KEYenvironmentvariable value to this string.
Set the access token key
Generate a new access token key using the following instructions:
Update the docker compose
services.server.environment.SUPERTOKENS_ACCESS_TOKEN_KEYenvironmentvariable value to the formatted string output.
Conclusion
After performing this updates you can run Hive Console without the need for the
supertokensservice. All the relevant authentication logic resides within the
servercontainer instead.Existing users in the supertokens system will continue to exist when running without the
supertokensservice.Patch Changes
3567483Thanks @jonathanawesome! - fix: correct RPM chart Y-axis
scale to match actual values