Conversation
Summary of ChangesHello @hasparus, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request extends the maximum limit for the "Pro" pricing tier from 300 million to 5 billion operations. It involves updating the range and display of the operations rate limit slider in the subscription management interface and adjusting the corresponding pricing plan logic and slider component in the documentation. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| <Slider | ||
| min={1} | ||
| max={300} | ||
| max={5000} |
There was a problem hiding this comment.
Increasing the slider maximum to 5000 (5B) on a linear scale makes it extremely difficult to select lower values precisely. For instance, 100M is now at the 2% mark. Consider using a logarithmic scale or adding a numeric input field for better precision, especially since intermediate labels like 100M/200M were removed.
| }} | ||
| /> | ||
| <span className="font-medium">{max}M</span> | ||
| <span className="font-medium">5B</span> |
There was a problem hiding this comment.
The end label '5B' is inconsistent with the start label '1M' (line 52) and the current value display (line 38), which still appends 'M' to the raw number (resulting in '5000 M' at the maximum). Units should be consistent across the component.
| className="mt-6 lg:mt-12" | ||
| onChange={value => { | ||
| const newPlan = value === 1 ? 'Hobby' : value < 280 ? 'Pro' : 'Enterprise'; | ||
| const newPlan = value === 1 ? 'Hobby' : value < 4800 ? 'Pro' : 'Enterprise'; |
There was a problem hiding this comment.
The Enterprise threshold (4800) is very close to the maximum, and the slider continues to show a calculated Pro price for values >= 4800 even though the Enterprise card is highlighted. The slider should ideally show 'Contact us' or hide the price once the Enterprise threshold is reached to avoid confusion.
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7717.hive-landing-page.pages.dev |
1 participant
Background
https://linear.app/the-guild/issue/CONSOLE-1866/change-pro-pricing-slider-up-to-5b
Description
Quick draft, didn't test it much yet, and I feel even with the slider already being logarithmic it might be a weird UX, gotta use it a bit.
Checklist