Add knip.dev to find unused files / exports / types / duplicates to allow for cleaning up the GraphCommerce codebase #2134

paales · 2023-11-30T11:19:57Z

Once we've cleaned up these files we can remove the barrel files from the "entry" configuration for packages to expose more.
Should we also create a github action that automatically comments any unused exports?

…llow for cleaning up the GraphCommerce codebase

vercel · 2023-11-30T11:20:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
graphcommerce	❌ Failed (Inspect)		Feb 13, 2024 8:21am
graphcommerce-hygraph-dynamic-rows-ui	✅ Ready (Inspect)	Visit Preview	Feb 13, 2024 8:21am

changeset-bot · 2023-11-30T11:20:04Z

⚠️ No Changeset found

Latest commit: 2a24f07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-11-30T12:57:30Z

Unused files (13)

examples/magento-graphcms/components/Layout/LayoutFull.tsx, examples/magento-graphcms/components/GraphCMS/RowColumnOne/RowColumnOneBoxed.tsx, examples/magento-graphcms/components/GraphCMS/RowColumnOne/RowColumnOneCentered.tsx, examples/magento-graphcms/components/GraphCMS/RowColumnOne/RowColumnOneDoubleSpread.tsx, examples/magento-graphcms/components/GraphCMS/RowColumnOne/RowColumnOneSpread.tsx, examples/magento-graphcms/components/GraphCMS/RowColumnTwo/RowColumnTwoSpread.tsx, packages/address-fields-nl/lib/nationaalgeoregister/resolver.ts, packages/magento-cart-items/components/CartItems/CartItems.tsx, packages/magento-cart-items/components/SelectedCustomizableOptions/index.ts, packages/mollie-magento-payment/Mollie.ts, packages/mollie-magento-payment/components/MollieOptionsToken/MollieCreditCardOptions.tsx, packages/mollie-magento-payment/components/MollieOptionsToken/MollieField.tsx, packages/mollie-magento-payment/components/MollieOptionsToken/mollieContext.ts

This reverts commit 43c3819.

# Conflicts: # package.json # packages/lighthouse/CHANGELOG.md # packages/lighthouse/package.json # yarn.lock

# Conflicts: # package.json # packages/lighthouse/CHANGELOG.md # packages/lighthouse/package.json # packagesDev/graphql-codegen-markdown-docs/src/graphql.ts # yarn.lock

Add knip.dev to find unused files / exports / types / duplicates to a…

d9cedea

…llow for cleaning up the GraphCommerce codebase

vercel bot deployed to Preview – graphcommerce November 30, 2023 11:21 View deployment

Try and add knip reporter

a4c599a

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 11:52 View deployment

Try and be in the correct directory

e9539b8

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 11:55 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 11:58 View deployment

Create a separate knip step

db64917

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:00 View deployment

Added knip as a dependency

9e43f29

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:02 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 12:05 View deployment

Downgrade knip to the latest 2.x branch

3a61412

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:22 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 12:25 View deployment

Run yarn codegen first before running knip

dd0d03a

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:38 View deployment

Run codegen in the correct directory

e7e1302

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:40 View deployment

Set correct directory

cdd704a

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:42 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 12:46 View deployment

knip: Disable plugins that might interfere

c0d7cfc

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 12:56 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 12:58 View deployment

paales added 2 commits November 30, 2023 14:18

Try and reset the directory

3152bf6

Rename .knip.jsonc to knip.json

43c3819

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:21 View deployment

paales added 2 commits November 30, 2023 14:23

Revert "Rename .knip.jsonc to knip.json"

bbc0190

This reverts commit 43c3819.

Ignore example directories

3e73b5e

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:26 View deployment

paales added 2 commits November 30, 2023 14:27

ignore test directory in packages

6cb53aa

Remove duplicate knip files

1a05c0a

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:30 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 13:35 View deployment

Remove example directory

052429e

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:37 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 13:39 View deployment

Try and ignore example directories

378ce2c

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:53 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 13:55 View deployment

Try and ignore

0a0484d

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 13:58 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 14:00 View deployment

Cleaned up repo and make sure the build doesn’t fail with knip failing

40b55c4

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 14:49 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 14:51 View deployment

Change flag to match actual code

9e730c3

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui November 30, 2023 15:03 View deployment

vercel bot deployed to Preview – graphcommerce November 30, 2023 15:05 View deployment

Merge branch 'canary' into fix/knip-cleanup

62e66e8

# Conflicts: # package.json # packages/lighthouse/CHANGELOG.md # packages/lighthouse/package.json # yarn.lock

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui January 15, 2024 13:46 View deployment

vercel bot had a problem deploying to Preview – graphcommerce January 15, 2024 13:47 Failure

Merge branch 'canary' into fix/knip-cleanup

2a24f07

# Conflicts: # package.json # packages/lighthouse/CHANGELOG.md # packages/lighthouse/package.json # packagesDev/graphql-codegen-markdown-docs/src/graphql.ts # yarn.lock

vercel bot deployed to Preview – graphcommerce-hygraph-dynamic-rows-ui February 13, 2024 08:21 View deployment

vercel bot had a problem deploying to Preview – graphcommerce February 13, 2024 08:21 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add knip.dev to find unused files / exports / types / duplicates to allow for cleaning up the GraphCommerce codebase #2134

Add knip.dev to find unused files / exports / types / duplicates to allow for cleaning up the GraphCommerce codebase #2134

Uh oh!

paales commented Nov 30, 2023 •

edited

Loading

Uh oh!

vercel bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Nov 30, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add knip.dev to find unused files / exports / types / duplicates to allow for cleaning up the GraphCommerce codebase #2134

Are you sure you want to change the base?

Add knip.dev to find unused files / exports / types / duplicates to allow for cleaning up the GraphCommerce codebase #2134

Uh oh!

Conversation

paales commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unused files (13)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paales commented Nov 30, 2023 •

edited

Loading

vercel bot commented Nov 30, 2023 •

edited

Loading

changeset-bot bot commented Nov 30, 2023 •

edited

Loading

github-actions bot commented Nov 30, 2023 •

edited

Loading