fix: don't exit immediately when no concluded workflow runs to retry#465
Draft
julienduchesne wants to merge 2 commits intografana:mainfrom
Draft
fix: don't exit immediately when no concluded workflow runs to retry#465julienduchesne wants to merge 2 commits intografana:mainfrom
julienduchesne wants to merge 2 commits intografana:mainfrom
Conversation
There is a race condition between GetCIStatus (GraphQL statusCheckRollup) and RerunFailedWorkflowsForCommit (REST ListRepositoryWorkflowRuns). The rollup reports failure as soon as any individual job fails, but the workflow run only gets a "failure" conclusion once all jobs complete. When one job fails while others are still running, the tool would find no retryable runs and exit immediately. Instead, continue polling so the next check cycle can retry once the workflow run has concluded. Co-authored-by: Cursor <cursoragent@cursor.com>
julienduchesne
force-pushed
the
fix/action-retries-race-condition
branch
from
8a34793 to
f0991ac
Compare
Contributor
Author
|
Waiting on #461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetCIStatus(GraphQLstatusCheckRollup) reports failure as soon as any individual job fails, butRerunFailedWorkflowsForCommit(RESTListRepositoryWorkflowRuns) only finds retryable runs once the workflow run has fully concluded. When one job fails while others are still running, the tool would find zero retryable runs and exit immediately with "CI failed with no GitHub Actions to retry".Test plan
TestPRCheckRetryWithInProgressWorkflowthat exercises the exact scenario: firstCheck()call returns 0 reruns (workflow in progress), second call returns 1 rerun (workflow concluded)Made with Cursor