Interfaces #3
Open
Interfaces #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrg94
suggested changes
Nov 25, 2025
There was a problem hiding this comment.
I don't know what's going on in the lib folder. You should be able to drop the JAR in there as-is. Seems like you might have unzipped it.
src/NeuronKernel.java
Outdated
| /** | ||
| * Queue of Strings to represent the values of each input. | ||
| */ | ||
| Queue<String> inputs = new Queue1L<>(); |
There was a problem hiding this comment.
There shouldn't be any variables in the interfaces.
src/NeuronKernel.java
Outdated
| /** | ||
| * Queue of values to represent the weights of each input. | ||
| */ | ||
| Queue<Double> weight = new Queue1L<>(); |
There was a problem hiding this comment.
Make sure the docs have proper contracts with preconditons and postconditions.
|
I think the hierarchy diagram is also missing. |
jrg94
approved these changes
Dec 8, 2025
| of it in this folder. You may also embed it just below using markdown syntax | ||
| (i.e., ``). | ||
|
|
||
| <!-- TODO: make a diagram of your component hierarchy then delete this comment --> |
There was a problem hiding this comment.
I don't believe PDFs can be embedded in markdown, but I was able to view the file.
| * @ensures {@code <weights> = weights} | ||
| * @return the queue of weight values | ||
| */ | ||
| Queue<Double> weights(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created two interfaces