Skip to content

Conversation

@ErichDonGubler
Copy link
Member

@ErichDonGubler ErichDonGubler commented Dec 22, 2025

Issue: #4538

Recommended review experience is commit-by-commit.


Requirements for PR author:

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@ErichDonGubler ErichDonGubler added the bug Something isn't working label Dec 22, 2025
@ErichDonGubler ErichDonGubler changed the title Max inter stage shader variables deduction per fragment input builtin maxInterStageShaderVariables: decrement max fragment input outputs per fragment input built-in Dec 22, 2025
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM.

This might explain some failures in Chrome/Dawn too.

@dneto0
Copy link
Contributor

dneto0 commented Dec 22, 2025

FYI: Run npm run fix to reformat the code

@ErichDonGubler ErichDonGubler force-pushed the maxInterStageShaderVariables-deduction-per-fragment-input-builtin branch from b907cca to 5587128 Compare December 22, 2025 20:40
@ErichDonGubler
Copy link
Member Author

NOTE: Per @kainino0x's question about coverage (see #4538 (comment)), I'm adding more coverage for the rest of the fragment input built-ins with d00cd2c. @dneto0: The re-review should be fast! 🙏🏻

@ErichDonGubler
Copy link
Member Author

Hmm…with the CI failures, I'm not sure how to handle this immediately. I'd rather lock in the reviewed-and-passing stuff I initially added, and break out the fix for gpuweb/gpuweb#5403 separately. I've rolled back to 5587128, and will file a separate issue/PR pair.

@ErichDonGubler ErichDonGubler force-pushed the maxInterStageShaderVariables-deduction-per-fragment-input-builtin branch from d00cd2c to 5587128 Compare December 22, 2025 21:02
@ErichDonGubler ErichDonGubler merged commit 41c23db into gpuweb:main Dec 22, 2025
2 checks passed
@ErichDonGubler ErichDonGubler deleted the maxInterStageShaderVariables-deduction-per-fragment-input-builtin branch December 22, 2025 21:54
@ErichDonGubler ErichDonGubler self-assigned this Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants