[GOVCMS-13360] Disable SAML SLO fallbacks. #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Current remote metadata configuration dynamically sets logout bindings. When no specific value for a logout binding is set, it falls back onto its corresponding login binding location. While this works for some IdP, this can cause issues with other IdPs that produce an error on attempts to process SP-initiated SingleLogoutService request.
In addition, it is arguably better to not enable SP-initiated SLO by default, and only do so on case-by-case basis.
Proposed solution
Introduce a check for
SIMPLESAMLPHP_SP_SLOenv variable with a default offalsewhen not present. Whenfalse, no fallback location will be used forSingleLogoutServicebinding, effectively deactivating SP-initiated SLO. Practically, this means that when the user logs out - the log out only happens from Drupal without involving IdP.