Tests for non-unit variant enum rotations#1
Open
nullstalgia wants to merge 2 commits intogorilskij:masterfrom
Open
Tests for non-unit variant enum rotations#1nullstalgia wants to merge 2 commits intogorilskij:masterfrom
nullstalgia wants to merge 2 commits intogorilskij:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ties into #1.
While experimenting with this macro, especially in a UI context, I found a repeated desire to have more than just unit variants cyclable in my enums.
Example:
I'll often have Enums like this one, where there's either a flow or a collection of states where the persistence of data across those states isn't of importance.
So using calls to
Default::default()for each field seemed like a reasonable compromise to me, although I would understand if you would prefer breaking this out into another trait/macro pair.I didn't edit any documentation or try to tackle every Clippy suggestion I saw, as I wanted to get your feedback first. :)
Thanks for the useful macro!