Skip to content

Conversation

@hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Dec 31, 2025

πŸ“‘ Description

βœ… Checks

  • Added test cases for my code

@gemini-code-assist
Copy link

Summary of Changes

Hello @hwbrzzl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant upgrade of the goravel/framework to version v1.17, necessitating a broad refactoring of the application's core structure. The primary goal is to modernize the application's bootstrapping process, centralize framework service access through a new facade pattern, and integrate advanced observability features via OpenTelemetry. These changes aim to improve maintainability, developer experience, and the overall robustness of the application by aligning it with the latest framework conventions.

Highlights

  • Framework Upgrade: The core goravel/framework dependency has been updated to a newer version (v1.17), bringing in various improvements and potentially breaking changes that necessitated significant refactoring across the application.
  • Application Bootstrapping Rework: The application's initialization process has been completely refactored in bootstrap/app.go. It now uses a new fluent API (foundation.Setup().With...().Run()) to configure components like commands, migrations, routing, events, jobs, rules, middleware, and gRPC interceptors, replacing the previous manual registration and kernel files.
  • Centralized Facades: A new app/facades directory has been introduced, providing a modular and explicit way to access framework services. Existing code that previously imported github.com/goravel/framework/facades has been updated to use these new local facades (e.g., goravel/app/facades).
  • Removal of Kernel and Service Provider Files: Several kernel.go files (e.g., for console, gRPC, HTTP, database) and individual service provider files have been removed. Their functionalities are now consolidated and managed through the new bootstrapping mechanism in bootstrap/app.go and bootstrap/providers.go.
  • OpenTelemetry Integration: A new config/telemetry.go file has been added, introducing comprehensive OpenTelemetry (OTel) configuration for traces, metrics, and logs. This includes settings for various exporters (OTLP, Zipkin, Console), samplers, and processors, enhancing the application's observability capabilities.
  • Build and Environment Configuration Updates: The .air.toml file has been updated to change temporary directory and build output paths from storage/temp to tmp. The .gitignore file has been expanded to include .env files, storage, and tmp directories, improving environment management and build artifact exclusion.
  • VSCode Launch Configuration: A new .vscode/launch.json file has been added, providing a default VSCode launch configuration for Goravel applications, which simplifies the debugging setup for developers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with πŸ‘ and πŸ‘Ž on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a major upgrade to v1.17, featuring a significant refactoring of the application bootstrapping process to a fluent foundation.Setup() API and the introduction of local facades. It also adds extensive OpenTelemetry support. The changes are extensive, removing many provider and kernel files in favor of a centralized bootstrap configuration.

My review has identified a few critical issues, including duplicate service provider registrations and disabled gRPC tracing interceptors that need to be addressed. I've also pointed out several medium-severity issues related to configuration, placeholder code, and gitignore rules that should be reviewed for a cleaner and more robust codebase.

}
return err
}
func OpentracingClient(ctx context.Context, method string, req, reply any, cc *grpc.ClientConn, invoker grpc.UnaryInvoker, opts ...grpc.CallOption) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we support telemetry out of the box, should we change the interceptor example to something else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will rename it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants