merge: v1.16.5 #87
Merged
merge: v1.16.5 #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: Upgrade framework to v1.16.3 (auto) * upgrade postgres v1.4.1 * optimize
* upgrade: v1.16.4 * upgrade: v1.16.4 * update mod
* fix: [#807] queue.Shutdown doesn't stop the queue as expected * upgrade: v1.16.5
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for Cloudinary as a filesystem driver, updates package versions from @master to @v1.4.x, improves the queue worker lifecycle management, and restructures validation requests. The changes include:
- Removal of Cloudinary filesystem driver integration
- Update of package installation/uninstallation test commands to use versioned packages
- Addition of worker shutdown handling in the main application
- Separation of validation concerns by creating a dedicated
ValidationCreaterequest - Enhancement of the User model with JSON field support for tags
Reviewed Changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/feature/filesystem_test.go | Removed Cloudinary driver test setup |
| package_test.go | Updated package versions from @master to @v1.4.x for all driver tests |
| main.go | Added worker shutdown handling in graceful shutdown flow |
| go.sum | Updated dependency checksums for various packages |
| go.mod | Removed Cloudinary dependency, updated package versions and toolchain |
| database/migrations/20210101000001_create_users_table.go | Added JSON tags field to users table |
| config/filesystems.go | Removed Cloudinary filesystem configuration |
| config/app.go | Removed Cloudinary service provider registration |
| app/models/user.go | Added Tags field with custom JSON serialization methods |
| app/http/requests/validation_create.go | New validation request with comprehensive validation rules |
| app/http/requests/user_create.go | Simplified user creation request focused on user fields |
| app/http/controllers/validation_controller.go | Updated to use new ValidationCreate request |
| app/http/controllers/user_controller.go | Added validation logic and expanded user creation |
| .github/workflows/test.yml | Removed Cloudinary environment variables |
| goravel | SQLite database file (binary, should be ignored) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Merge v1.16.5
✅ Checks