Modernize Android qrcode module with CameraX and zxing-cpp #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Forgot to say, zxing-cpp is licensed under Apache 2.0 license so it is compatible with this project's license. |
The qrcode module used deprecated APIs like android.hardware.Camera and Play Services Vision API. Replace these with AndroidX CameraX and open source zxing-cpp. zxing-cpp works on all devices, no matter if they have Play Services or not.
|
Thanks @nift4 for your pull request! As you said, the qrcode module uses deprecated APIs and they should be replaced. Although your changes seem reasonable, our plan is to migrate the qrcode module to use ML Kit as it is recommended in the com.google.android.gms.vision guide. In case you'd like to propose the required changes for the migration to ML Kit, your help will be very much appreciated. Thanks! |
Author
|
Hi, is there no chance to merge this PR with zxing-cpp? It is open source and does not increase APK size as much as MLKit does. Thanks, Nick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The qrcode module used deprecated APIs like android.hardware.Camera and Play Services Vision API. Replace these with AndroidX CameraX and open source zxing-cpp. zxing-cpp works on all devices, no matter if they have Play Services or not. I have tested this on my headset and can confirm QR scanning works fine.