fix: wire --latest-tag-version CLI option to ManifestOptions#2653
Open
rabadin wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: wire --latest-tag-version CLI option to ManifestOptions#2653rabadin wants to merge 1 commit intogoogleapis:mainfrom
rabadin wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The `--latest-tag-version` and `--latest-tag-sha` CLI options are defined but not wired up to `ManifestOptions`, making them non-functional. This change wires these options to `ManifestOptions`. This enables scenarios where the latest release version cannot be automatically discovered and thus needs to be passed via CLI options.
rabadin
force-pushed
the
fix-latest-tag-cli-options
branch
from
668bd70 to
20a9b06
Compare
product-auto-label
bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--latest-tag-versionand--latest-tag-shaCLI options are defined but not wired up toManifestOptions, making them non-functional.This change wires these options to
ManifestOptions.This enables scenarios where the latest release version cannot be automatically discovered and thus needs to be passed via CLI options.