Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7d604cd to
382ce4b
Compare
36c2c7a to
dd52bb5
Compare
c6ede81 to
105e4f3
Compare
chingor13
left a comment
There was a problem hiding this comment.
Thanks for this! It seems reasonable, but the tests are failing.
@chingor13 I've updated the listing rules! Would it be possible for you to enable CI for this PR? |
3efd21d to
3db8e03
Compare
e614b88 to
abc2f9b
Compare
|
This is ready for review! Tests should be passing, and I've opened a draft PR in a Julia monorepo I maintain as an example. |
abc2f9b to
89c49e1
Compare
|
@chingor13 could you please enable CI once again? I've done some more testing locally, and I'm confident tests will pass (for non-Windows tests at least, where I'm able to test locally). |
| "bin": "./build/src/bin/release-please.js", | ||
| "scripts": { | ||
| "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test", | ||
| "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test", |
There was a problem hiding this comment.
I'm unsure about this change, but I needed it to run tests locally.
|
@chingor13 could you please enable CI? I think tests should pass now. |
Julia projects have their versions specified in their dependency files, not their lock files. Their dependency files can be named
JuliaProject.tomlor (more commonly)Project.toml. Each package version is held by the'version'key in the project TOML file. This makesrelease-pleaseparsing simple!Fixes #2152