Skip to content

fix: fix links error when using GitHub Enterprise#2350

Open
goatwu1993 wants to merge 1 commit intogoogleapis:mainfrom
goatwu1993:chore/better-default-changelog-host
Open

fix: fix links error when using GitHub Enterprise#2350
goatwu1993 wants to merge 1 commit intogoogleapis:mainfrom
goatwu1993:chore/better-default-changelog-host

Conversation

@goatwu1993
Copy link
Contributor

@goatwu1993 goatwu1993 commented Aug 7, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

With this update, while release-please/release-please-actions runs in GitHub Enterprise actions/workflow, the links by default is correct.

Fixes #2351 🦕

@goatwu1993 goatwu1993 requested review from a team as code owners August 7, 2024 10:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Aug 7, 2024
@goatwu1993 goatwu1993 closed this Aug 8, 2024
@goatwu1993 goatwu1993 reopened this Aug 8, 2024
@goatwu1993 goatwu1993 changed the title fix: fix some links point to github.com when using github enterprise fix: fix links error when using GitHub Enterprise Aug 8, 2024
@goatwu1993
Copy link
Contributor Author

@chingor13 please take a look?

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and sorry for the long delay

@goatwu1993 goatwu1993 requested a review from chingor13 November 11, 2024 03:28
@goatwu1993
Copy link
Contributor Author

goatwu1993 commented Nov 14, 2024

@chingor13 updated.

please review again

NOTE: this has some duplication with the input changelog host and i am not sure if these two inputs changelog-host & server-url should be aliased

@ferrarimarco
Copy link
Collaborator

Hi @goatwu1993. Can you please have a look at updating tests in test/cli.ts?

@goatwu1993 goatwu1993 force-pushed the chore/better-default-changelog-host branch 2 times, most recently from 26ae964 to 8c16d34 Compare February 4, 2026 05:44
@goatwu1993 goatwu1993 force-pushed the chore/better-default-changelog-host branch from 64e96b9 to e2f5a9b Compare February 4, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When using release-please on GitHub enterprise, some links at changelog/release points to github

4 participants