Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 13, 2026

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

Generation failed for

  • google-cloud-datastore

…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
@parthea
Copy link
Contributor Author

parthea commented Jan 13, 2026

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/python-datastore API. labels Jan 13, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on the comprehensive removal of the google-cloud-datastore client library and its administrative counterpart (google-cloud-datastore-admin) from the repository. This extensive deletion, triggered by an updated librarian image, suggests a significant restructuring or deprecation of these components within this project, possibly in response to a reported generation failure for google-cloud-datastore.

Highlights

  • Librarian Image Update: The python-librarian-generator Docker image has been updated to a new SHA256 hash: 51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8.
  • Client Library Removal: The google-cloud-datastore and google-cloud-datastore-admin client libraries, including all their source code, documentation, and metadata files, have been entirely removed from the repository.
  • Development Configuration Cleanup: Various development-related configuration files, such as .pre-commit-config.yaml, .trampolinerc, noxfile.py, renovate.json, and SECURITY.md, have been deleted.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@parthea parthea closed this Jan 13, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the librarian image and removes several files related to the google-cloud-datastore library. The image update is a straightforward replacement, but the file removals indicate a potential shift in how the library is managed or structured. No specific style guide was provided, so the review focuses on correctness and potential implications of the changes.

I am having trouble creating individual review comments. Click here to see my feedback.

google/cloud/datastore_admin_v1/services/datastore_admin/transports/rest.py (1-2178)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/transports/rest.py file has been removed. This file defines the REST transport for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/init.py (1-122)

critical

The google/cloud/datastore_v1/types/__init__.py file has been removed. This file initializes the datastore v1 types package. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

.repo-metadata.json (1-17)

critical

The .repo-metadata.json file has been removed. This file contains metadata about the repository, such as its name, description, and documentation links. Removing it might affect tooling or processes that rely on this metadata. It's a critical decision to remove this file.

.trampolinerc (1-61)

critical

The .trampolinerc file has been removed. This file configures the trampoline, which is used to run commands in a Docker container. Removing it might affect the build and test processes. It's a critical decision to remove this file.

README.rst (1-201)

critical

The README.rst file has been removed. This file provides information about the google-cloud-datastore library. Removing it makes it harder for users to understand and use the library. It's a critical decision to remove this file.

SECURITY.md (1-7)

critical

The SECURITY.md file has been removed. This file outlines the security policy for the repository, including how to report security vulnerabilities. Removing it could make it harder for users to report security issues. It's a critical decision to remove this file.

docs/README.rst (1-201)

critical

The docs/README.rst file has been removed. This file provides documentation for the google-cloud-datastore library. Removing it makes it harder for users to understand and use the library. It's a critical decision to remove this file.

docs/summary_overview.md (1-22)

critical

The docs/summary_overview.md file has been removed. This file provides a summary overview of the APIs available for the Google Cloud Datastore API. Removing it makes it harder for users to understand the library. It's a critical decision to remove this file.

google/cloud/datastore_admin/init.py (1-76)

critical

The google/cloud/datastore_admin/__init__.py file has been removed. This file initializes the datastore admin package. Removing it will break the datastore admin functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin/gapic_version.py (1-16)

critical

The google/cloud/datastore_admin/gapic_version.py file has been removed. This file defines the version of the datastore admin GAPIC. Removing it will break the datastore admin functionality. It's a critical decision to remove this file.

renovate.json (1-12)

critical

The renovate.json file has been removed. This file configures the Renovate bot, which automatically updates dependencies. Removing it will stop automatic dependency updates, which could lead to security vulnerabilities and compatibility issues. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/init.py (1-70)

critical

The google/cloud/datastore_admin_v1/__init__.py file has been removed. This file initializes the datastore admin v1 package. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/gapic_metadata.json (1-118)

critical

The google/cloud/datastore_admin_v1/gapic_metadata.json file has been removed. This file maps proto services/RPCs to the corresponding library clients/methods. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/gapic_version.py (1-16)

critical

The google/cloud/datastore_admin_v1/gapic_version.py file has been removed. This file defines the version of the datastore admin v1 GAPIC. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

noxfile.py (1-535)

critical

The noxfile.py file has been removed. This file defines the nox sessions for the project. Removing it will break the testing and development workflow. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/init.py (1-15)

critical

The google/cloud/datastore_admin_v1/services/__init__.py file has been removed. This file initializes the datastore admin v1 services package. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/init.py (1-22)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/__init__.py file has been removed. This file initializes the datastore admin v1 services datastore_admin package. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/async_client.py (1-1386)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/async_client.py file has been removed. This file defines the asynchronous client for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/client.py (1-1786)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/client.py file has been removed. This file defines the client for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/pagers.py (1-197)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/pagers.py file has been removed. This file defines the pagers for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/transports/README.rst (1-9)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/transports/README.rst file has been removed. This file describes the transport inheritance structure. Removing it will make it harder to understand the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/transports/init.py (1-38)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/transports/__init__.py file has been removed. This file initializes the datastore admin v1 transports package. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/transports/base.py (1-323)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/transports/base.py file has been removed. This file defines the base transport class for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc.py (1-677)

critical

The google/cloud/datastore_admin_v1/services/datastore_admin/transports/grpc.py file has been removed. This file defines the gRPC transport for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

.pre-commit-config.yaml (1-31)

critical

The .pre-commit-config.yaml file has been removed. This file defines the pre-commit hooks used in the repository. Removing it disables these checks, which could lead to a decrease in code quality and consistency. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/types/datastore_admin.py (1-640)

critical

The google/cloud/datastore_admin_v1/types/datastore_admin.py file has been removed. This file defines the data types for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/query_profile.py (1-144)

critical

The google/cloud/datastore_v1/types/query_profile.py file has been removed. This file defines the query profile data types for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/types/index.py (1-181)

critical

The google/cloud/datastore_admin_v1/types/index.py file has been removed. This file defines the index data types for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/types/migration.py (1-201)

critical

The google/cloud/datastore_admin_v1/types/migration.py file has been removed. This file defines the migration data types for the datastore admin v1 service. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/init.py (1-122)

critical

The google/cloud/datastore_v1/__init__.py file has been removed. This file initializes the datastore v1 package. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/gapic_metadata.json (1-148)

critical

The google/cloud/datastore_v1/gapic_metadata.json file has been removed. This file maps proto services/RPCs to the corresponding library clients/methods. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/gapic_version.py (1-16)

critical

The google/cloud/datastore_v1/gapic_version.py file has been removed. This file defines the version of the datastore v1 GAPIC. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/query.py (1-1035)

critical

The google/cloud/datastore_v1/types/query.py file has been removed. This file defines the query data types for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/init.py (1-15)

critical

The google/cloud/datastore_v1/services/__init__.py file has been removed. This file initializes the datastore v1 services package. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/init.py (1-22)

critical

The google/cloud/datastore_v1/services/datastore/__init__.py file has been removed. This file initializes the datastore v1 services datastore package. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/async_client.py (1-1520)

critical

The google/cloud/datastore_v1/services/datastore/async_client.py file has been removed. This file defines the asynchronous client for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/client.py (1-1921)

critical

The google/cloud/datastore_v1/services/datastore/client.py file has been removed. This file defines the client for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/transports/README.rst (1-9)

critical

The google/cloud/datastore_v1/services/datastore/transports/README.rst file has been removed. This file describes the transport inheritance structure. Removing it will make it harder to understand the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/transports/init.py (1-38)

critical

The google/cloud/datastore_v1/services/datastore/transports/__init__.py file has been removed. This file initializes the datastore v1 transports package. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/transports/base.py (1-368)

critical

The google/cloud/datastore_v1/services/datastore/transports/base.py file has been removed. This file defines the base transport class for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/services/datastore/transports/rest_base.py (1-650)

critical

The google/cloud/datastore_v1/services/datastore/transports/rest_base.py file has been removed. This file defines the base REST transport class for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_admin_v1/types/init.py (1-66)

critical

The google/cloud/datastore_admin_v1/types/__init__.py file has been removed. This file initializes the datastore admin v1 types package. Removing it will break the datastore admin v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/aggregation_result.py (1-101)

critical

The google/cloud/datastore_v1/types/aggregation_result.py file has been removed. This file defines the aggregation result data types for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/datastore.py (1-1317)

critical

The google/cloud/datastore_v1/types/datastore.py file has been removed. This file defines the data types for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

google/cloud/datastore_v1/types/entity.py (1-394)

critical

The google/cloud/datastore_v1/types/entity.py file has been removed. This file defines the entity data types for the datastore v1 service. Removing it will break the datastore v1 functionality. It's a critical decision to remove this file.

.librarian/state.yaml (1)

high

The image has been updated. Ensure that this new image is tested and verified to be working as expected. It's a critical change that affects the entire librarian process.

google/cloud/datastore_v1/py.typed (1-2)

medium

The google/cloud/datastore_v1/py.typed file has been removed. This file is a marker file for PEP 561, indicating that the google-cloud-datastore package uses inline types. Removing it might affect type checking. It's a medium decision to remove this file.

google/cloud/datastore_admin_v1/py.typed (1-2)

medium

The google/cloud/datastore_admin_v1/py.typed file has been removed. This file is a marker file for PEP 561, indicating that the google-cloud-datastore package uses inline types. Removing it might affect type checking. It's a medium decision to remove this file.

google/cloud/datastore_admin/py.typed (1-2)

medium

The google/cloud/datastore_admin/py.typed file has been removed. This file is a marker file for PEP 561, indicating that the google-cloud-datastore package uses inline types. Removing it might affect type checking. It's a medium decision to remove this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant