feat: support biglake tables in pandas_gbq.sample #1014
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| # Copyright (c) 2026 pandas-gbq Authors All rights reserved. | ||
| # Use of this source code is governed by a BSD-style | ||
| # license that can be found in the LICENSE file. | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import dataclasses | ||
|
|
||
| import google.auth.transport.requests | ||
| import google.oauth2.credentials | ||
|
|
||
| _ICEBERG_REST_CATALOG_URI = "https://biglake.googleapis.com/iceberg/v1/restcatalog" | ||
| _TABLE_METADATA_PATH = ( | ||
| "/v1/projects/{project}/catalogs/{catalog}/namespaces/{namespace}/tables/{table}" | ||
| ) | ||
|
|
||
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class BigLakeTableId: | ||
| project: str | ||
| catalog: str | ||
| namespace: str | ||
| table: str | ||
|
|
||
|
|
||
| def get_table_metadata( | ||
| *, | ||
| table_id: str, | ||
| credentials: google.oauth2.credentials.Credentials, | ||
| billing_project_id: str, | ||
| ): | ||
| """ | ||
| Docstring for get_table_metadata | ||
| https://iceberg.apache.org/spec/#metrics; | ||
| curl -X GET -H "Authorization: Bearer \"$(gcloud auth application-default print-access-token)\"" \ | ||
| -H "Content-Type: application/json; charset=utf-8" \ | ||
| -H 'x-goog-user-project: swast-scratch' \ | ||
| -H 'X-Iceberg-Access-Delegation: vended-credentials' \ | ||
| """ | ||
| # https://iceberg.apache.org/spec/#metrics | ||
| # total-files-size | ||
| project, catalog, namespace, table = table_id.split(".") | ||
|
Contributor
There was a problem hiding this comment. Unpacking parts = table_id.split(".")
if len(parts) != 4:
raise ValueError(
"Invalid BigLake table ID. Expected format: "
"project.catalog.namespace.table"
)
project, catalog, namespace, table = parts |
||
| session = google.auth.transport.requests.AuthorizedSession(credentials=credentials) | ||
| path = _TABLE_METADATA_PATH.format( | ||
| project=project, | ||
| catalog=catalog, | ||
| namespace=namespace, | ||
| table=table, | ||
| ) | ||
| return session.get( | ||
| f"{_ICEBERG_REST_CATALOG_URI}.{path}", | ||
| headers={ | ||
| "x-goog-user-project": billing_project_id, | ||
| "Content-Type": "application/json; charset=utf-8", | ||
| # TODO(tswast): parameter for this option (or get from catalog metadata?) | ||
| # /iceberg/{$api_version}/restcatalog/extensions/{name=projects/*/catalogs/*} | ||
| "X-Iceberg-Access-Delegation": "vended-credentials", | ||
| }, | ||
| ).json() | ||
|
Comment on lines
+52
to
+61
Contributor
There was a problem hiding this comment. The URL for the BigLake REST API is constructed incorrectly. There's an extra response = session.get(
f"{_ICEBERG_REST_CATALOG_URI}{path}",
headers={
"x-goog-user-project": billing_project_id,
"Content-Type": "application/json; charset=utf-8",
# TODO(tswast): parameter for this option (or get from catalog metadata?)
# /iceberg/{$api_version}/restcatalog/extensions/{name=projects/*/catalogs/*}
"X-Iceberg-Access-Delegation": "vended-credentials",
},
)
response.raise_for_status()
return response.json() |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring for
get_table_metadatais a placeholder. Please add a proper docstring explaining the function's purpose, its parameters (table_id,credentials,billing_project_id), and what it returns. This is important for maintainability and usability.