Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
braydonk
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks like a good start. Can you also add an integration test case that leverages a .editorconfig? The guidance for how to add a test case is here:
https://github.com/google/yamlfmt/blob/main/docs/integration-test.md#add-new-test-case
| gopkg.in/ini.v1 v1.67.0 // indirect | ||
| ) | ||
|
|
||
| require ( |
There was a problem hiding this comment.
I think this need a go mod tidy; not sure why it added this extra require block.
There was a problem hiding this comment.
Hmm, that's a good question. Another good one is why go mod tidy only touches go.sum...
Sure! I'm just thinking that this probably isn't as straight forward as I thought. The "Automatic search for |
Yup, that's the case. So basically |
Fixes #61.