Skip to content

Internal #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 3, 2025
Merged

Internal #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ type Device struct {
model string

// Partitioning Information
// TODO (b/151981913) This remains a string for now to retain compatibility
// with main. It will eventually be moved to type 'partition'.
partStyle glstor.PartitionStyle
partitions []Partition
}
Expand Down
1 change: 0 additions & 1 deletion storage/storage_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ func (part *Partition) Mount(base string) error {
return nil
}
// Skip partitions that cannot be mounted.
// TODO(b/130833261) Revisit not throwing an error here during OSS.
if part.fileSystem == UnknownFS {
return nil
}
Expand Down
1 change: 0 additions & 1 deletion storage/storage_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,6 @@ func (part *Partition) Mount(letter string) error {
if part.fileSystem == UnknownFS {
return nil
}
// TODO(b/130833261) We need to check for Admin here and skip if we are not.

// Assign partitions to everything else.
available, err := freeDrive(letter)
Expand Down