Skip to content

Conversation

@Aaryan-549
Copy link

Resolves #802

Description

This PR fixes missing dependencies that caused ImportError when running example scripts in OSS environment.

Issues Fixed:

  1. ImportError: cannot import name 'storage' from 'google.cloud' at train_deepscaler_nb.py:151
  2. ModuleNotFoundError: No module named 'gcsfs' at train_deepscaler_nb.py:234

Changes:

  • Added google-cloud-storage to dependencies (required for GCS file operations in OSS environment)
  • Added gcsfs to dependencies (required for accessing gs:// URIs via fsspec)

Both dependencies are used by example notebooks (train_deepscaler_nb.py, math_eval_nb.py) to access Google Cloud Storage buckets for data and models.

Reference

Colab Notebook
N/A - This is a dependency fix, not a new API addition.

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • [x ] I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Fail to run train_deepscaler_nb.py

1 participant