Skip to content

Conversation

@jboddey
Copy link
Contributor

@jboddey jboddey commented May 15, 2024

The certificate is not automatically trusted for Chrome. The user must manually import the certificate by following this guide: https://docs.vmware.com/en/VMware-Adapter-for-SAP-Landscape-Management/2.1.0/Installation-and-Administration-Guide-for-VLA-Administrators/GUID-D60F08AD-6E54-4959-A272-458D08B8B038.html

Documentation is yet to be added to this PR.

@jboddey jboddey changed the title Generate and SSL certificate for Testrun UI Generate SSL certificate for Testrun UI May 15, 2024
@jboddey
Copy link
Contributor Author

jboddey commented May 23, 2024

Any opinions on the implementation of this @jhughesbiot?

@jboddey jboddey added this to the Release 1.3 milestone May 24, 2024
@jboddey jboddey self-assigned this May 24, 2024
@jboddey jboddey modified the milestones: Release 1.3, Release 1.4 Jul 12, 2024
@jhughesoti jhughesoti self-requested a review August 30, 2024 14:51
Fix paths for cert generation
Fix root path reference
@jhughesoti
Copy link
Contributor

@jboddey Fixed a few issues so this should be good to go.
One thing I noticed is that the auto trusting of the cert will only work for connections directly on the same machine and won't work for remote connections. Similar to the MDNS registered domain so i'm not sure even trusting it, without a proper MDNS network configuration if this will solve browser auth errors but it does at least add HTTPS.

@jhughesoti
Copy link
Contributor

@jboddey I can't seem to get this to actually work anymore, UI module keeps crashing.

@jboddey jboddey closed this Oct 2, 2024
@jboddey jboddey reopened this Nov 22, 2024
Signed-off-by: J Boddey <boddey@google.com>
@jboddey
Copy link
Contributor Author

jboddey commented Nov 22, 2024

This no longer works because the UI connects to the ws server using an insecure port (so it doesn't load). In order to continue, we would need to add TLS to the web sockets server.

@jboddey jboddey closed this Nov 22, 2024
@jboddey jboddey deleted the feature/ssl_cert branch December 19, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants