Skip to content

The Non-complient test with Required if Applicable value is not highlighted in the results list on UI #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 2 commits into from
Dec 23, 2025
+5 −11
Merged

The Non-complient test with Required if Applicable value is not highlighted in the results list on UI #1394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e68e0c
Highlight non-compliant test result; update version (the current rele…
sofyakurilova Dec 22, 2025
8cf5ef3
Merge branch 'dev' into bug/test_result_non_compliant
sofyakurilova Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions make/DEBIAN/control
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: Testrun
Version: 2.2.1
Version: 2.2.2
Architecture: amd64
Maintainer: Google <boddey@google.com>
Maintainer: Google <ssm-orcas@google.com>
Homepage: https://github.com/google/testrun
Bugs: https://github.com/google/testrun/issues
Description: Automatically verify IoT device network behavior
Expand Down
4 changes: 1 addition & 3 deletions modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@
<mat-cell mat-cell *matCellDef="let element">
<span
class="cell-result-text"
[class.highlight]="
isNonCompliantAndRequired(element.result, element.required_result)
"
[class.highlight]="isNonCompliant(element.result)"
[ngClass]="getResultClass(element.result)">
<span>{{ element.result }}</span>
</span>
Expand Down
8 changes: 2 additions & 6 deletions modules/ui/src/app/pages/testrun/components/testrun-table/testrun-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
} from '@angular/core';
import {
IResult,
RequiredResult,
StatusOfTestResult,
StatusResultClassName,
} from '../../../../model/testrun-status';
Expand Down Expand Up @@ -103,10 +102,7 @@ export class TestrunTableComponent {
return item.name + item.result;
}

public isNonCompliantAndRequired(result: string, requiredResult: string) {
return (
result === StatusOfTestResult.NonCompliant &&
requiredResult === RequiredResult.Required
);
public isNonCompliant(result: string) {
return result === StatusOfTestResult.NonCompliant;
}
}
Loading