Change regular expression to satisfy the requirements #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hitnik
approved these changes
Oct 20, 2025
sofyakurilova
added a commit
that referenced
this pull request
Oct 23, 2025
* Show loader for stopping status (#1299) * Fix settings update (#1300) Co-authored-by: J Boddey <boddey@google.com> * Highlight Required if possible and Required with Non-Compliant result (#1305) * 409766621: (feat) add clear search button (#1307) * Calculate tests count for first page (#1306) * Calculate tests count for first page * refactor first page calculation --------- Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com> * 418729718: (fix) change error message view for the same port selected (#1308) * Add details feild to the test case result * pylint * fix "details" key error * 416241072: (feat) provide further context in test results (#1309) * 413638736: (fix) change design for discard popup (#1310) * 410565507: (fix) changes to close form when creating via actions button (#1311) * 410583302: (fix) changes for prevent RA disappeared after copy (#1315) * 421374390: (fix) change save risk profile popup design (#1316) * As create date does not contain time, the validator change to compare profile (#1317) * Change menu for outdated device (#1318) * 410583302: (fix) changes for prevent profile disappeared after copy (#1319) * Align the details by center (#1320) * 421375877: (fix) remove actions menu for copy profile (#1322) * Change order of inputs (#1324) * Adds new status for easier profile management (#1325) * Change condition as value can be null (#1327) * Clear copy is profile status is not Copy (#1328) * refactor _connection_ipaddr_ip_change * refactor _connection_dhcp_address * refactor _connection_mac_address * refactor _connection_mac_oui * fix oui not found * refactor of _connection_target_ping * refactor _connection_ipaddr_dhcp_failover * refactor _connection_dhcp_disconnect * refactor _connection_ipv6_slaac * refactor _connection_ipv6_ping * refactor setup_single_dhcp_server * refactor _change_subnet * pylint * added time to risk profile creation date * device created_at, modified_at field * FE: Refactor RA date format - add time (#1331) * Adds device sorting * Fix tests * change device creation approach * add details to report json * split details to list * refactor split test results to pages approach * Adds styles for details * qualification test details * fix report variables * Do not insert copy when the same copy is already exist (#1339) * Fix css (#1341) * Hide scroll for items list (#1342) * fix text aligment and add title * place details under the description field * Service module timeout fix (#1333) * discover open posrt before full scan * tsp ports discover refactor * refactor service module tests no-complient * scan only http port in TLS module * description line break * Do not highlight the error row (#1352) * Get updated tip element after timeout to prevent focus previous (undefined) tip (#1354) * Fix tooltips (#1355) * fix ip.dst keyerror * error messages * fix pyshark error * fix not_valid_before depracation warning * fix tests deprecation warning * pylint * fix inconsistent quotas * refactor https_detect * set timeout to 5 seconds * pylint * Fix npm audit issues (#1366) * docs: fix typo DEGUG → DEBUG in log level example * update python dependancies * update grcpio * update risk profiles * convert details to the list of strings * unit tests * pylint * change dns module styles * unit tests * detecting https using requests module * pylint * Change the method to count test results (#1373) * Highlight row when test result non compliant and required (#1374) * Change regular expression to satisfy the requirements (#1376) * Show "Welcome modal" when the version is updated (#1377) * change details display method * Bump version --------- Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Olga Mardvilko <mardvilka@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com>
sofyakurilova
added a commit
that referenced
this pull request
Dec 17, 2025
* Show loader for stopping status (#1299) * Fix settings update (#1300) * Highlight Required if possible and Required with Non-Compliant result (#1305) * 409766621: (feat) add clear search button (#1307) * Calculate tests count for first page (#1306) * Calculate tests count for first page * refactor first page calculation --------- * 418729718: (fix) change error message view for the same port selected (#1308) * Add details feild to the test case result * pylint * fix "details" key error * 416241072: (feat) provide further context in test results (#1309) * 413638736: (fix) change design for discard popup (#1310) * 410565507: (fix) changes to close form when creating via actions button (#1311) * 410583302: (fix) changes for prevent RA disappeared after copy (#1315) * 421374390: (fix) change save risk profile popup design (#1316) * As create date does not contain time, the validator change to compare profile (#1317) * Change menu for outdated device (#1318) * 410583302: (fix) changes for prevent profile disappeared after copy (#1319) * Align the details by center (#1320) * 421375877: (fix) remove actions menu for copy profile (#1322) * Change order of inputs (#1324) * Adds new status for easier profile management (#1325) * Change condition as value can be null (#1327) * Clear copy is profile status is not Copy (#1328) * refactor _connection_ipaddr_ip_change * refactor _connection_dhcp_address * refactor _connection_mac_address * refactor _connection_mac_oui * fix oui not found * refactor of _connection_target_ping * refactor _connection_ipaddr_dhcp_failover * refactor _connection_dhcp_disconnect * refactor _connection_ipv6_slaac * refactor _connection_ipv6_ping * refactor setup_single_dhcp_server * refactor _change_subnet * pylint * added time to risk profile creation date * device created_at, modified_at field * FE: Refactor RA date format - add time (#1331) * Adds device sorting * Fix tests * change device creation approach * add details to report json * split details to list * refactor split test results to pages approach * Adds styles for details * qualification test details * fix report variables * Do not insert copy when the same copy is already exist (#1339) * Fix css (#1341) * Hide scroll for items list (#1342) * fix text aligment and add title * place details under the description field * Service module timeout fix (#1333) * discover open posrt before full scan * tsp ports discover refactor * refactor service module tests no-complient * scan only http port in TLS module * description line break * Do not highlight the error row (#1352) * Get updated tip element after timeout to prevent focus previous (undefined) tip (#1354) * Fix tooltips (#1355) * fix ip.dst keyerror * error messages * fix pyshark error * fix not_valid_before depracation warning * fix tests deprecation warning * pylint * fix inconsistent quotas * refactor https_detect * set timeout to 5 seconds * pylint * Fix npm audit issues (#1366) * docs: fix typo DEGUG → DEBUG in log level example * update python dependancies * update grcpio * update risk profiles * convert details to the list of strings * unit tests * pylint * change dns module styles * unit tests * detecting https using requests module * pylint * Change the method to count test results (#1373) * Highlight row when test result non compliant and required (#1374) * Change regular expression to satisfy the requirements (#1376) * Show "Welcome modal" when the version is updated (#1377) * change details display method * Bump version --------- Co-authored-by: J Boddey <boddey@google.com> Co-authored-by: Olga Mardvilko <mardvilka@google.com> Co-authored-by: Aliaksandr Nikitsin <aliaksandrn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firmware field is not validated properly