Skip to content

Fix DNS modules table #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hitnik merged 2 commits into from
Oct 14, 2025
Merged

Fix DNS modules table #1371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5883397
change dns module styles
hitnik Oct 10, 2025
32ee9cf
unit tests
hitnik Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions modules/test/dns/resources/report_template.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
<tbody>
{% for row in module_data %}
<tr>
<td><div>{{ row['src'] }}</div></td>
<td><div>{{ row['dst'] }}</div></td>
<td><div>{{ row['res_ip'] }}</div></td>
<td><div>{{ row['typ'] }}</div></td>
<td><div>{{ row['dat'] }}</div></td>
<td class="count-row"><div>{{ row['count'] }}</div></td>
<td class='dns-ip'><div>{{ row['src'] }}</div></td>
<td class='dns-ip'><div>{{ row['dst'] }}</div></td>
<td class='dns-ip'><div>{{ row['res_ip'] }}</div></td>
<td class='dns-type'><div>{{ row['typ'] }}</div></td>
<td class='dns-url'><div>{{ row['dat'] }}</div></td>
<td class='dns-count'><div>{{ row['count'] }}</div></td>
</tr>
{% endfor %}
</tbody>
Expand Down
24 changes: 17 additions & 7 deletions resources/report/test_report_styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,20 +231,30 @@

.module-data.dns-module thead tr th,
.module-data.dns-module tbody tr td {
padding: 12px 16px;
padding: 12px 6px;
}

.module-data.dns-module tbody tr td {
max-width: 1px;
.module-data.dns-module tbody tr td.dns-ip {
max-width: 130px;
}

.module-data.dns-module tbody tr td.count-row {
width: 1px;
.module-data.dns-module tbody tr td.dns-type {
max-width: 70px;
}

.module-data.dns-module tbody tr td.dns-count {
width: 10px;
}

.module-data.dns-module tbody tr td.dns-count div {
text-align: center;
}
.module-data.dns-module tbody tr td.dns-url {
max-width: 285px;
}

.module-data.dns-module tbody tr td div {
word-wrap: break-word;
overflow-wrap: break-word;
word-break: break-all;
}

div.steps-to-resolve {
Expand Down
96 changes: 48 additions & 48 deletions testing/unit/dns/reports/dns_report_local.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,68 +48,68 @@ <h4 class="page-heading">DNS Module</h4>
</thead>
<tbody>
<tr>
<td><div>10.10.10.14</div></td>
<td><div>10.10.10.4</div></td>
<td><div>N/A</div></td>
<td><div>Query</div></td>
<td><div>mqtt.googleapis.com</div></td>
<td class="count-row"><div>64</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>N/A</div></td>
<td class='dns-type'><div>Query</div></td>
<td class='dns-url'><div>mqtt.googleapis.com</div></td>
<td class='dns-count'><div>64</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>173.194.195.206</div></td>
<td><div>Response</div></td>
<td><div>mqtt.googleapis.com</div></td>
<td class="count-row"><div>38</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>173.194.195.206</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>mqtt.googleapis.com</div></td>
<td class='dns-count'><div>38</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>2607:f8b0:4001:c11::ce</div></td>
<td><div>Response</div></td>
<td><div>mqtt.googleapis.com</div></td>
<td class="count-row"><div>32</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>2607:f8b0:4001:c11::ce</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>mqtt.googleapis.com</div></td>
<td class='dns-count'><div>32</div></td>
</tr>
<tr>
<td><div>10.10.10.14</div></td>
<td><div>10.10.10.4</div></td>
<td><div>N/A</div></td>
<td><div>Query</div></td>
<td><div>pool.ntp.org</div></td>
<td class="count-row"><div>7</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>N/A</div></td>
<td class='dns-type'><div>Query</div></td>
<td class='dns-url'><div>pool.ntp.org</div></td>
<td class='dns-count'><div>7</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>N/A</div></td>
<td><div>Response</div></td>
<td><div>pool.ntp.org</div></td>
<td class="count-row"><div>4</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>N/A</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>pool.ntp.org</div></td>
<td class='dns-count'><div>4</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>5.78.89.3</div></td>
<td><div>Response</div></td>
<td><div>pool.ntp.org</div></td>
<td class="count-row"><div>2</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>5.78.89.3</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>pool.ntp.org</div></td>
<td class='dns-count'><div>2</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>199.68.201.234</div></td>
<td><div>Response</div></td>
<td><div>pool.ntp.org</div></td>
<td class="count-row"><div>2</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>199.68.201.234</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>pool.ntp.org</div></td>
<td class='dns-count'><div>2</div></td>
</tr>
<tr>
<td><div>10.10.10.4</div></td>
<td><div>10.10.10.14</div></td>
<td><div>2607:f8b0:4001:c08::ce</div></td>
<td><div>Response</div></td>
<td><div>mqtt.googleapis.com</div></td>
<td class="count-row"><div>6</div></td>
<td class='dns-ip'><div>10.10.10.4</div></td>
<td class='dns-ip'><div>10.10.10.14</div></td>
<td class='dns-ip'><div>2607:f8b0:4001:c08::ce</div></td>
<td class='dns-type'><div>Response</div></td>
<td class='dns-url'><div>mqtt.googleapis.com</div></td>
<td class='dns-count'><div>6</div></td>
</tr>
</tbody>
</table>
Expand Down