Skip to content

Place details under the description field #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hitnik merged 1 commit into from
Jul 24, 2025
Merged

Place details under the description field #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework/python/src/common/testreport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def _add_page_counter(self, html):

def _calc_details_height(self, text):
# Calculate a details line height
lines = math.ceil(len(text) / 100)
lines = math.ceil(len(text) / 45)
return (lines * 14) + 12

def _gen_result_page(self, results, space):
Expand Down
15 changes: 12 additions & 3 deletions resources/report/test_report_styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,16 @@
border-top: 0;
}

.result-line-result-details {
.result-line-result-with-details {
border-top: 0;
border-bottom: 0;
}

.result-line-result-details {
height: auto;
border-top: 0;
}

.result-line-result-non-compliant-required {
background: #FCE8E6;
}
Expand Down Expand Up @@ -483,8 +488,12 @@

.result-test-details {
font-size: 11px;
margin-left: 3.6px;
padding: 6px;
width: 300px;
display: block;
margin-left: 2.1in;
margin-right: 0;
margin-bottom: 6px;
box-sizing: border-box;
}

.result-test-result-error {
Expand Down
8 changes: 4 additions & 4 deletions resources/test_packs/pilot/report_templates/results.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
{% for test_result in page %}
{% if test_result['result'] == 'Non-Compliant' and test_result['required_result'] in ["Required", "Required if Applicable"] %}
{% if test_result['details']%}
<div class="result-line result-line-result-details result-line-result-non-compliant-required">
{% else %}
<div class="result-line result-line-result result-line-result-non-compliant-required">
<div class="result-line result-line-result-with-details result-line-result-non-compliant-required">
{% else%}
<div class="result-line result-line-result result-line-result-non-compliant-required">
{% endif %}
{% else %}
{% if test_result['details']%}
<div class="result-line result-line-result-details">
<div class="result-line result-line-result-with-details">
{% else %}
<div class="result-line result-line-result">
{% endif %}
Expand Down
8 changes: 4 additions & 4 deletions resources/test_packs/qualification/report_templates/results.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
{% for test_result in page %}
{% if test_result['result'] == 'Non-Compliant' and test_result['required_result'] in ["Required", "Required if Applicable"] %}
{% if test_result['details']%}
<div class="result-line result-line-result-details result-line-result-non-compliant-required">
{% else %}
<div class="result-line result-line-result result-line-result-non-compliant-required">
<div class="result-line result-line-result-with-details result-line-result-non-compliant-required">
{% else%}
<div class="result-line result-line-result result-line-result-non-compliant-required">
{% endif %}
{% else %}
{% if test_result['details']%}
<div class="result-line result-line-result-details">
<div class="result-line result-line-result-with-details">
{% else %}
<div class="result-line result-line-result">
{% endif %}
Expand Down